Skip to content

fix: allow eslint@^9.x as a peer dependency #9413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AhmedBaset
Copy link

@AhmedBaset AhmedBaset commented Jun 23, 2024

Every time I pnpm i (not sure about other package managers), i get a warning about the peer dependency eslint v9.

pnpm i output in the terminal with warnings, some of them relates to @typescript-eslint/*

According to semver.npmjs.com:

  • ^8.56.0 matches only 8.56.0 and 8.57.0.
  • ^8.56.0 || ^9.0.0 matches them and 9.x.x
^8.56.0 ^8.56.0 || ^9.0.0
server.npmjs.com report about 8.56 server.npmjs.com report about 8.56 || 9.0.0

PR Checklist

Overview

This PR updates the peer dependency to ^8.56.0 || ^9.0.0

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @AhmedBaset!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 23, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f7a612b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66785413fded3200082bee33
😎 Deploy Preview https://deploy-preview-9413--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jun 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f7a612b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@AhmedBaset AhmedBaset changed the title Allow eslint@^9.x as peerDependencies fix: Allow eslint@^9.x as peerDependencies Jun 23, 2024
@AhmedBaset AhmedBaset changed the title fix: Allow eslint@^9.x as peerDependencies fix: allow eslint@^9.x as a peer dependency Jun 23, 2024
@rubiesonthesky
Copy link
Contributor

Eslint v9 support will be added in next major version of typescript-eslint. That major version is worked on branch v8 and already accepts eslint v9.

You can test beta version of 8, if you follow the pinned issues #9141

@bradzacher bradzacher closed this Jun 23, 2024
@AhmedBaset AhmedBaset deleted the eslint-9.x-peer branch June 23, 2024 23:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants