Skip to content

chore: revert 'chore(deps): update nx to v19.3.0 #9371' #9418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 24, 2024

Reverts #9371.

The weekly release is failing, and I really should have consulted with @JamesHenry before moving us off the canary. Sorry 😄

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 08db94a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6679ad0d6e7a0c0009387b05
😎 Deploy Preview https://deploy-preview-9418--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jun 24, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 08db94a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JamesHenry
Copy link
Member

@JoshuaKGoldberg I imagine it's just that the patch is no longer being applied correctly? Sorry that that is still required right now

@JoshuaKGoldberg
Copy link
Member Author

Maybe! I'd rather look at it separately, want to get the release out the door heh.

@JoshuaKGoldberg JoshuaKGoldberg merged commit cc11eae into typescript-eslint:main Jun 24, 2024
20 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the revert-nx-v19.3.0 branch June 24, 2024 17:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants