Skip to content

docs: use correct types for node in "Explicity node types" documentation #9461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

maks-rafalko
Copy link
Contributor

PR Checklist

Overview

Issue is described in #9457

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @maks-rafalko!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 30, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 221b8d8
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6682446c9074a10008f3c870
😎 Deploy Preview https://deploy-preview-9461--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@maks-rafalko maks-rafalko changed the title docs: Use correct types for node in "Explicity node types" documentation docs: use correct types for node in "Explicity node types" documentation Jun 30, 2024
Copy link

nx-cloud bot commented Jun 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 221b8d8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Comment on lines 236 to 240
import {
AST_NODE_TYPES,
ESLintUtils,
TSESTree,
} from '@typescript-eslint/utils';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like AST_NODE_TYPES is no longer used in this example. What do you think about removing it?

Suggested change
import {
AST_NODE_TYPES,
ESLintUtils,
TSESTree,
} from '@typescript-eslint/utils';
import { TSESTree, ESLintUtils } from '@typescript-eslint/utils';

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. ESLintUtils is also not used in this snipped, removed.

@auvred auvred added the awaiting response Issues waiting for a reply from the OP or another party label Jun 30, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎇

@auvred auvred removed the awaiting response Issues waiting for a reply from the OP or another party label Jul 1, 2024
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@auvred auvred merged commit f138ffd into typescript-eslint:main Jul 1, 2024
65 checks passed
@maks-rafalko maks-rafalko deleted the patch-2 branch July 1, 2024 06:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants