-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: use correct types for node in "Explicity node types" documentation #9461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @maks-rafalko! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 221b8d8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
docs/developers/Custom_Rules.mdx
Outdated
import { | ||
AST_NODE_TYPES, | ||
ESLintUtils, | ||
TSESTree, | ||
} from '@typescript-eslint/utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like AST_NODE_TYPES
is no longer used in this example. What do you think about removing it?
import { | |
AST_NODE_TYPES, | |
ESLintUtils, | |
TSESTree, | |
} from '@typescript-eslint/utils'; | |
import { TSESTree, ESLintUtils } from '@typescript-eslint/utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. ESLintUtils
is also not used in this snipped, removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
PR Checklist
Overview
Issue is described in #9457