chore(eslint-plugin): re-using logic from builtinSymbolLike in no-implied-eval #9462
Conversation
|
Thanks for the PR, @YutongZhuu! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9462 +/- ##
=======================================
Coverage 88.26% 88.26%
=======================================
Files 417 417
Lines 14413 14406 -7
Branches 4208 4205 -3
=======================================
- Hits 12721 12716 -5
Misses 1372 1372
+ Partials 320 318 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -76,14 +76,8 @@ export default createRule({ | |||
| } | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison | |||
There was a problem hiding this comment.
| // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison |
It looks like this eslint-disable directive is no longer required.
PR Checklist
type-utils#8234Overview
I use the function in isBuiltinSymbolLike.ts to replace similar logic. But I am passing a string 'FunctionConstructor' to a function instead of Function since there is a test case where the symbol name is FunctionConstructor. I am not sure if this is the right thing to do.