Skip to content

fix(eslint-plugin): [no-floating-promises] add suggestions to tests from #9263 checkThenables #9515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2024
Merged

fix(eslint-plugin): [no-floating-promises] add suggestions to tests from #9263 checkThenables #9515

merged 1 commit into from
Jul 8, 2024

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Jul 8, 2024 •
edited by kirkwaiblinger
Loading

PR Checklist

Overview

Adds suggestions property that was missing in tests from #9263 causing pipeline failures in main.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 8, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d4018e8
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/668b2de6cfe665000892c07f
😎 Deploy Preview https://deploy-preview-9515--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 8, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d4018e8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@abrahamguo abrahamguo changed the title fix(eslint-plugin): [no-floating-promises] add suggestions to tests from #9263 fix(eslint-plugin): [no-floating-promises] add suggestions to tests from #9263 checkThenables Jul 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (3e19436) to head (d4018e8).
Report is 252 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##           main    #9515       +/-   ##
=========================================
+ Coverage      0   88.37%   +88.37%     
=========================================
  Files         0      419      +419     
  Lines         0    14618    +14618     
  Branches      0     4279     +4279     
=========================================
+ Hits          0    12919    +12919     
- Misses        0     1375     +1375     
- Partials      0      324      +324
Flag Coverage Δ
unittest 88.37% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 413 files with indirect coverage changes

kirkwaiblinger
kirkwaiblinger approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kirkwaiblinger kirkwaiblinger merged commit 3c6290d into typescript-eslint:main Jul 8, 2024
76 checks passed
@JoshuaKGoldberg
Copy link
Member

Whoops, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(eslint-plugin): [no-floating-promises] missing suggestions property on tests from #9263 checkThenables
3 participants
@abrahamguo @JoshuaKGoldberg @kirkwaiblinger