Skip to content

chore(eslint-plugin): [no-unnecessary-parameter-property-assignment] remove fixable from meta #9527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2024
Merged

chore(eslint-plugin): [no-unnecessary-parameter-property-assignment] remove fixable from meta #9527

merged 1 commit into from
Jul 9, 2024

Conversation

dasa
Copy link
Contributor

@dasa dasa commented Jul 9, 2024

No fixer is actually present.

Ref: #8903 (comment)

PR Checklist

Overview

@dasa
chore: remove fixable from meta
c0bf4b9 
No fixer is actually present.

Ref: #8903 (comment)
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @dasa!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 9, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c0bf4b9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/668d67385449190008723c89
😎 Deploy Preview https://deploy-preview-9527--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 9, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c0bf4b9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@dasa dasa changed the title chore(eslint-plugin): [no-unnecessary-parameter-property-assignment]: remove fixable from meta chore(eslint-plugin): [no-unnecessary-parameter-property-assignment] remove fixable from meta Jul 9, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A great first PR 😄

@JoshuaKGoldberg JoshuaKGoldberg merged commit bebbd0c into typescript-eslint:main Jul 9, 2024
59 of 62 checks passed
@dasa dasa deleted the patch-1 branch July 9, 2024 16:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dasa @JoshuaKGoldberg