fix(typescript-estree): disable includePackageJsonAutoImports in ProjectService #9586
Conversation
|
Thanks for the PR, @jakebailey! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3b896fb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
The heck |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9586 +/- ##
==========================================
+ Coverage 88.38% 88.40% +0.01%
==========================================
Files 419 422 +3
Lines 14620 14651 +31
Branches 4279 4285 +6
==========================================
+ Hits 12922 12952 +30
Misses 1374 1374
- Partials 324 325 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
packages/typescript-estree/src/create-program/createProjectService.ts
Outdated
Show resolved
Hide resolved
What are those..? Will that cause us to lose any type coverage? |
|
@bradzacher this is our side of microsoft/TypeScript#59338 (comment). There's more work to be done, but this should be a good improvement to start. |
There was a problem hiding this comment.
Thanks (as usual) for hopping on this @jakebailey + @sheetalkamat! ❤️
TS needs a way to analyze code for auto imports, but it can't do that in the main Program for the current code because that would end up loading stuff like potentially unreferenced ambients. So, it instead loads those other libraries in a AutoImportProviderProject separately so they can be analyzed and provide completions / fixes. There's no need for that in your case, so it's just wasted work. |
The issue doesn't say what they are! |
|
Did you see my explanation above? This will have no effect on your usage at all. |
|
I didn't see it cos the GH mobile app is so bad at doing anything useful 😅 Makes sense! Kill it! |
863eb86
into
typescript-eslint:main
PR Checklist
Overview
Per microsoft/TypeScript#59338 (comment), disable this so that the auto import projects are not used.