Skip to content

chore(website): correct version to be v8, not latest merged v7 #9593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2024
Merged

chore(website): correct version to be v8, not latest merged v7 #9593

merged 3 commits into from
Jul 19, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Hardcodes the version to 'v8'. The root issue is that our versioning infra doesn't touch the package.jsons directly, so they still say the latest v7 version in them & get imported into components with that...

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 19, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5456ea9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/669a6d5a2a9aa10008356b00
😎 Deploy Preview https://deploy-preview-9593--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 19, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5456ea9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review July 19, 2024 12:02
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team July 19, 2024 12:02
bradzacher
bradzacher approved these changes Jul 19, 2024
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 19, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit d26e1d1 into typescript-eslint:v8 Jul 19, 2024
63 of 65 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the v8-version-on-site branch July 19, 2024 14:56
@github-actions github-actions bot mentioned this pull request Jul 19, 2024
Closed
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaKGoldberg @bradzacher @kirkwaiblinger