Skip to content

feat(eslint-plugin): [return-await] add return-await to strict-type-checked preset #9604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Jul 22, 2024

BREAKING CHANGE Technically not a breaking change, since it's only going to the strict config, but targeting v8 anyway to batch it in with the rest of our config changes.

PR Checklist

Overview

Nothin but a config change

Note, also, followup to #9595, thanks @JoshuaKGoldberg for the tip on the config generation infra


Co-authored-by: @JoshuaKGoldberg

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1bf49fd
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/669df61f3d155e00088d5820
😎 Deploy Preview https://deploy-preview-9604--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirkwaiblinger kirkwaiblinger changed the base branch from main to v8 July 22, 2024 05:48
Copy link

nx-cloud bot commented Jul 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1bf49fd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 swell!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 22, 2024
@kirkwaiblinger kirkwaiblinger merged commit 88a8673 into typescript-eslint:v8 Jul 22, 2024
71 of 72 checks passed
@kirkwaiblinger kirkwaiblinger deleted the return-await-preset branch July 22, 2024 13:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configs: include return-await in strict-type-checked preset
2 participants