Skip to content

docs: switch Typed Linting docs to project service #9614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Goes through our first-run docs to suggest parserOptions.projectService instead of parserOptions.project.

For the FAQs files, splits into Project Service Issues and Traditional Project Issues headings, respectively.

Does not update the parser package's docs themselves (/packages/parser#projectservice). I'm still waiting on performance investigations to know how to frame things (#9571).

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team July 22, 2024 23:16
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Jul 22, 2024
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 11e8579
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66a00d397532ae00081028c7
😎 Deploy Preview https://deploy-preview-9614--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jul 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 11e8579. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (f3dfc0a) to head (11e8579).
Report is 12 commits behind head on v8.

Additional details and impacted files
@@           Coverage Diff           @@
##               v8    #9614   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files         401      401           
  Lines       13637    13637           
  Branches     3960     3960           
=======================================
  Hits        12003    12003           
  Misses       1325     1325           
  Partials      309      309           
Flag Coverage Δ
unittest 88.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@auvred auvred added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 29, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 8197f71 into typescript-eslint:v8 Jul 29, 2024
64 of 65 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the typed-linting-docs-project-service branch July 29, 2024 11:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants