fix(eslint-plugin): [no-unnecessary-type-assertion] prevent runtime error when asserting a variable declared in default TS lib #9660
Conversation
…rror when asserting a variable declared in default TS lib
|
Thanks for the PR, @auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cc5d830. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9660 +/- ##
=======================================
Coverage 88.45% 88.45%
=======================================
Files 422 422
Lines 14695 14696 +1
Branches 4298 4299 +1
=======================================
+ Hits 12998 12999 +1
Misses 1372 1372
Partials 325 325
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PR Checklist
Overview
As Kirk mentioned in #9268 (comment), we can't rely on ESTree because the variable can be declared in the TS default lib, so we don't even have a corresponding ESTree AST.