Skip to content

docs: add v8 release announcement blog post #9661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 29, 2024

PR Checklist

Overview

Does a similar approach to v6's announcement:

  1. Adds a copy & past of the beta post to a new stable one, with names & paths updated
  2. Updates the beta post to point to the stable one
  3. Updates the code snippet showing the config diff

Also adds in the list of community projects & plugins that tried out v8 with their maintainers under thanks.

Code that generated v7->v8 config diffs
{
  "dependencies": {
    "@typescript-eslint/eslint-plugin-7": "npm:@typescript-eslint/eslint-plugin@7",
    "@typescript-eslint/eslint-plugin-8": "npm:@typescript-eslint/eslint-plugin@rc-v8"
  },
  "type": "module"
}
import tseslint7 from '@typescript-eslint/eslint-plugin-7';
import tseslint8 from '@typescript-eslint/eslint-plugin-8';

function createDiffPatch(v7, v8) {
  const v7Keys = new Set(Object.keys(v7));
  const v8Keys = new Set(Object.keys(v8));
  const output = ['{'];

  for (const key of Array.from(new Set([...v7Keys, ...v8Keys])).sort((a, b) =>
    trimSlash(a).localeCompare(trimSlash(b)),
  )) {
    const prefix = v7Keys.has(key) ? (v8Keys.has(key) ? ' ' : '-') : '+';

    output.push(`${prefix}  '${key}': '...',`);
  }

  output.push('}');

  return output.join('\n');
}

function trimSlash(text) {
  return text.startsWith('@typescript-eslint/')
    ? text.slice('@typescript-eslint/'.length)
    : text;
}

const configNames = [
  'recommended',
  'recommended-type-checked',
  'strict',
  'strict-type-checked',
  'stylistic',
  'stylistic-type-checked',
];

for (const configName of configNames) {
  console.log(configName);
  console.log(
    createDiffPatch(
      tseslint7.configs[configName].rules,
      tseslint8.configs[configName].rules,
    ),
  );
}

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Jul 29, 2024
Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e4af77d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66a7bcc6cb9ff400085d9252
😎 Deploy Preview https://deploy-preview-9661--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jul 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e4af77d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

bradzacher
bradzacher previously approved these changes Jul 29, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 29, 2024
…v8.md

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (6b92aa5) to head (e4af77d).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9661   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files         422      422           
  Lines       14695    14722   +27     
  Branches     4298     4309   +11     
=======================================
+ Hits        12998    13023   +25     
- Misses       1372     1374    +2     
  Partials      325      325           
Flag Coverage Δ
unittest 88.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg added the DO NOT MERGE PRs which should not be merged yet label Jul 29, 2024
@JoshuaKGoldberg
Copy link
Member Author

Noting that we'll want to merge this on Wednesday & trigger a manual website release.

@JoshuaKGoldberg JoshuaKGoldberg removed the DO NOT MERGE PRs which should not be merged yet label Jul 30, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 8e7eb68 into typescript-eslint:main Jul 31, 2024
65 of 67 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the v8-announce-post branch July 31, 2024 15:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add final announcement blog post for v8
2 participants