-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(typescript-eslint): add JSDoc comments on generated configs #9672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript-eslint): add JSDoc comments on generated configs #9672
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Adding the |
Could you test this in the IDE? I suspect it won't and instead this would need to be placed in a type on this variable https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/src/index.ts#L55 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9672 +/- ##
=======================================
Coverage 87.92% 87.92%
=======================================
Files 402 402
Lines 13726 13726
Branches 3999 3999
=======================================
Hits 12069 12069
Misses 1351 1351
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. |
90576fa
into
typescript-eslint:main
PR Checklist
Overview
Syncs the descriptions from their docs pages on https://typescript-eslint.io/users/configs.