Skip to content

fix(typescript-estree): factor tsconfigRootDir into allowDefaultProject #9675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix(typescript-estree): factor tsconfigRootDir into allowDefaultProject #9675

merged 1 commit into from
Jul 31, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

The "does this file's path match the allowed list of files" needed to be relative to tsconfigRootDir, not the absolute path.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Jul 30, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 30, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ebc7b29
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66a8f05ad6d12200084c800d
😎 Deploy Preview https://deploy-preview-9675--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 30, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ebc7b29. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (838dd0c) to head (ebc7b29).
Report is 15 commits behind head on v8.

Additional details and impacted files 
@@           Coverage Diff           @@
##               v8    #9675   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files         402      402           
  Lines       13657    13658    +1     
  Branches     3967     3967           
=======================================
+ Hits        12026    12027    +1     
  Misses       1322     1322           
  Partials      309      309
Flag Coverage Δ
unittest 88.05% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...escript-estree/src/useProgramFromProjectService.ts 100.00% <100.00%> (ø)

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(typescript-estree): factor tsconfigRootDir into allowDefaultProje… fix(typescript-estree): factor tsconfigRootDir into allowDefaultProject Jul 30, 2024
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team July 30, 2024 18:06
kirkwaiblinger
kirkwaiblinger approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 30, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 48fc385 into typescript-eslint:v8 Jul 31, 2024
64 of 67 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the project-service-default-project-relative-to-tsconfig-root-dir branch July 31, 2024 15:17
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Closed
4 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Aug 3, 2024
Closed
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaKGoldberg @bradzacher @kirkwaiblinger