Skip to content

docs(eslint-plugin): [no-unnecessary-type-parameters] add admonition about rule's potential for subtlety #9690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

docs(eslint-plugin): [no-unnecessary-type-parameters] add admonition about rule's potential for subtlety #9690

merged 1 commit into from
Jul 31, 2024

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

For your consideration @JoshuaKGoldberg

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 31, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c82a6c0
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66aa6853ffd4200008b091eb
😎 Deploy Preview https://deploy-preview-9690--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirkwaiblinger kirkwaiblinger changed the base branch from main to v8 July 31, 2024 16:37
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 31, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c82a6c0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I like this phrasing :)

@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review July 31, 2024 16:49
@kirkwaiblinger kirkwaiblinger merged commit ce09260 into typescript-eslint:v8 Jul 31, 2024
60 of 61 checks passed
@kirkwaiblinger kirkwaiblinger deleted the NUTP-admonition branch July 31, 2024 16:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirkwaiblinger @JoshuaKGoldberg