-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(eslint-plugin): [no-unnecessary-type-parameters] skip checking function bodies for AST references #9738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
…nction bodies for AST references
78dccf3
to
74ebf98
Compare
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 74ebf98. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9738 +/- ##
==========================================
- Coverage 88.07% 88.06% -0.02%
==========================================
Files 402 402
Lines 13693 13697 +4
Branches 3982 3985 +3
==========================================
+ Hits 12060 12062 +2
- Misses 1324 1325 +1
- Partials 309 310 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fe56157
into
typescript-eslint:main
PR Checklist
Overview
Prevents checking of references inside a function body, or if one doesn't exist, generally after the return type.
This might give a little speed boost for not checking function bodies... but:
💖