Skip to content

chore(eslint-plugin): make utility for static member access #9836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Sep 13, 2024
Merged

chore(eslint-plugin): make utility for static member access #9836

merged 21 commits into from
Sep 13, 2024

Conversation

abrahamguo
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@abrahamguo abrahamguo marked this pull request as draft August 20, 2024 11:56
@netlify Netlify
Copy link

netlify bot commented Aug 20, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 61f766e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66d62d50b275090008cd96d1
😎 Deploy Preview https://deploy-preview-9836--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 20, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 61f766e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.08%. Comparing base (f44da95) to head (61f766e).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/eslint-plugin/src/rules/prefer-includes.ts 0.00% 2 Missing ⚠️
...int-plugin/src/rules/require-array-sort-compare.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9836      +/-   ##
==========================================
- Coverage   88.12%   88.08%   -0.05%     
==========================================
  Files         406      406              
  Lines       13951    13937      -14     
  Branches     4076     4069       -7     
==========================================
- Hits        12294    12276      -18     
- Misses       1344     1349       +5     
+ Partials      313      312       -1
Flag Coverage Δ
unittest 88.08% <91.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...t-plugin/src/rules/class-literal-property-style.ts 100.00% <100.00%> (ø)
.../eslint-plugin/src/rules/class-methods-use-this.ts 88.88% <100.00%> (+1.93%) ⬆️
...plugin/src/rules/explicit-module-boundary-types.ts 90.07% <100.00%> (-1.23%) ⬇️
...es/eslint-plugin/src/rules/no-floating-promises.ts 98.62% <100.00%> (-0.06%) ⬇️
packages/eslint-plugin/src/rules/prefer-find.ts 100.00% <100.00%> (ø)
...t-plugin/src/rules/prefer-promise-reject-errors.ts 100.00% <100.00%> (ø)
...t-plugin/src/rules/prefer-reduce-type-parameter.ts 100.00% <100.00%> (ø)
...ages/eslint-plugin/src/rules/prefer-regexp-exec.ts 97.95% <100.00%> (+0.08%) ⬆️
...plugin/src/rules/prefer-string-starts-ends-with.ts 97.47% <100.00%> (+0.02%) ⬆️
...rc/rules/use-unknown-in-catch-callback-variable.ts 100.00% <100.00%> (ø)
... and 3 more

@abrahamguo abrahamguo marked this pull request as ready for review September 2, 2024 17:09
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 lovely, nice cleanup. Thanks for this!

@JoshuaKGoldberg JoshuaKGoldberg merged commit c11ca06 into typescript-eslint:main Sep 13, 2024
59 checks passed
@auvred auvred mentioned this pull request Sep 14, 2024
Merged
3 tasks
@kirkwaiblinger kirkwaiblinger mentioned this pull request Sep 16, 2024
Closed
4 tasks
@abrahamguo abrahamguo deleted the get-static-key-value branch September 17, 2024 01:58
@abrahamguo abrahamguo restored the get-static-key-value branch September 17, 2024 01:58
@abrahamguo abrahamguo deleted the get-static-key-value branch September 17, 2024 01:59
@abrahamguo abrahamguo mentioned this pull request Sep 17, 2024
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Make utility for static member access
2 participants
@abrahamguo @JoshuaKGoldberg