chore: enable eslint-plugin-perfectionist on ast-spec package #9842
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| raw: string; | ||
| type: AST_NODE_TYPES.Literal; |
There was a problem hiding this comment.
I would love it if we could force type to be first, always.
I'm not going to block on it as alpha sorting is king.
But for ast-spec specifically always defining type first is really nice.
There was a problem hiding this comment.
Yeah, agreed. I can mess around with https://perfectionist.dev/rules/sort-imports#groups ...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9842 +/- ##
=======================================
Coverage 88.04% 88.04%
=======================================
Files 407 407
Lines 13948 13948
Branches 4078 4078
=======================================
Hits 12280 12280
Misses 1355 1355
Partials 313 313
Flags with carried forward coverage won't be shown. Click here to find out more. |
88b44ce
into
typescript-eslint:main
PR Checklist
Overview
Enables sorting on
packages/ast-spec.💖