Skip to content

chore: enable eslint-plugin-perfectionist on parser package #9845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 24, 2024
Merged

chore: enable eslint-plugin-perfectionist on parser package #9845

merged 4 commits into from
Aug 24, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Enables sorting on packages/parser.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 20, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0c83d20
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66ca1ebef37b550008a2bc35
😎 Deploy Preview https://deploy-preview-9845--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 20, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0c83d20. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft August 20, 2024 20:09
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 20, 2024 20:41
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team August 20, 2024 20:41
bradzacher
bradzacher previously approved these changes Aug 21, 2024
View reviewed changes
packages/parser/tests/lib/parser.test.ts
Comment on lines +33 to +35
sourceType: 'module' as const,
// ts-estree specific
errorOnTypeScriptSyntacticAndSemanticIssues: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's cool - i like how it respects the comment as a sorting delineator.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 21, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (88b44ce) to head (0c83d20).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9845   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         407      407           
  Lines       13948    13948           
  Branches     4078     4078           
=======================================
  Hits        12280    12280           
  Misses       1355     1355           
  Partials      313      313
Flag Coverage Δ
unittest 88.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9612d81 into typescript-eslint:main Aug 24, 2024
57 of 59 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the perfectionist-parser branch August 24, 2024 19:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @bradzacher