chore: enable eslint-plugin-perfectionist on rule-schema-to-typescript-types package #9846
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| import type { | ||
| JSONSchema4, | ||
| JSONSchema4ArraySchema, | ||
| } from '@typescript-eslint/utils/json-schema'; | ||
|
|
||
| import { TSUtils } from '@typescript-eslint/utils'; | ||
|
|
||
| import type { ArrayAST, AST, RefMap, TupleAST, UnionAST } from './types'; | ||
|
|
There was a problem hiding this comment.
2c: I dislike this style of splitting type-only imports from value imports.
I personally didn't really like the grouping at all, but simple-import-sort used to be the "best autofixable" rule.
Question: Can we turn import grouping off entirely?
Given all relative imports are prefixed with ./ or ../ -- the relative imports are already "grouped".
If not, w/e -- it's autofixed.
There was a problem hiding this comment.
Yeah, we should be able to. I commented #8479 (comment) to make sure it's done as part of #8479.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9846 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 407 407
Lines 13941 13941
Branches 4071 4071
=======================================
Hits 12273 12273
Misses 1355 1355
Partials 313 313
Flags with carried forward coverage won't be shown. Click here to find out more. |
30d4eae
into
typescript-eslint:main
PR Checklist
Overview
Enables sorting on
packages/rule-schema-to-typescript-types.💖