chore: enable eslint-plugin-perfectionist on scope-manager package #9848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9848 +/- ##
==========================================
- Coverage 86.10% 86.09% -0.01%
==========================================
Files 428 428
Lines 14955 14968 +13
Branches 4337 4342 +5
==========================================
+ Hits 12877 12887 +10
Misses 1734 1734
- Partials 344 347 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bradzacher
requested changes
Aug 21, 2024
packages/scope-manager/src/definition/FunctionNameDefinition.ts
Outdated
Show resolved
Hide resolved
packages/scope-manager/src/definition/ImplicitGlobalVariableDefinition.ts
Outdated
Show resolved
Hide resolved
packages/scope-manager/src/definition/ImportBindingDefinition.ts
Outdated
Show resolved
Hide resolved
packages/scope-manager/src/definition/TSEnumMemberDefinition.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
bradzacher
previously approved these changes
Aug 23, 2024
bradzacher
requested changes
Aug 24, 2024
JoshuaKGoldberg
commented
Oct 10, 2024
|
Ok I'm tired of dealing with merge conflicts, will just merge now. Someone yell at me if anything's amiss. Note the touchups on the ESLint config to fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Enables sorting on
packages/scope-manager.💖