Skip to content

chore: enable eslint-plugin-perfectionist on type-utils package #9849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2024
Merged

chore: enable eslint-plugin-perfectionist on type-utils package #9849

merged 2 commits into from
Oct 17, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Enables sorting on packages/type-utils.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 20, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 35f23ff
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/670933eed348ff000893fec1
😎 Deploy Preview https://deploy-preview-9849--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft August 20, 2024 20:09
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 20, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 35f23ff. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 20, 2024 21:05
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team August 20, 2024 21:05
@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.09%. Comparing base (865209d) to head (35f23ff).
Report is 23 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9849   +/-   ##
=======================================
  Coverage   86.09%   86.09%           
=======================================
  Files         428      428           
  Lines       14968    14969    +1     
  Branches     4342     4343    +1     
=======================================
+ Hits        12887    12888    +1     
  Misses       1734     1734           
  Partials      347      347
Flag Coverage Δ
unittest 86.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/type-utils/src/TypeOrValueSpecifier.ts 100.00% <100.00%> (ø)
packages/type-utils/src/builtinSymbolLikes.ts 4.91% <ø> (ø)
packages/type-utils/src/getContextualType.ts 5.00% <ø> (ø)
packages/type-utils/src/isTypeReadonly.ts 87.50% <100.00%> (ø)
packages/type-utils/src/isUnsafeAssignment.ts 84.37% <100.00%> (ø)
.../src/typeOrValueSpecifiers/specifierNameMatches.ts 100.00% <100.00%> (ø)
...ls/src/typeOrValueSpecifiers/typeDeclaredInFile.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

bradzacher
bradzacher approved these changes Aug 21, 2024
View reviewed changes
@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 25, 2024
@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party and removed 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels Aug 25, 2024
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft September 2, 2024 21:13
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review October 11, 2024 14:20
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 11, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit c08895e into typescript-eslint:main Oct 17, 2024
63 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the perfectionist-type-utils branch October 17, 2024 22:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @bradzacher