Skip to content

chore: enable eslint-plugin-perfectionist on typescript-estree package #9852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 21, 2024
Merged

chore: enable eslint-plugin-perfectionist on typescript-estree package #9852

merged 5 commits into from
Oct 21, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Enables sorting on packages/typescript-estree.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 20, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9859b92
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6711839df3373500080a35fe
😎 Deploy Preview https://deploy-preview-9852--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 94 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 20, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9859b92. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.45205% with 133 lines in your changes missing coverage. Please review.

Project coverage is 86.14%. Comparing base (7effdea) to head (9859b92).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 48.00% 104 Missing and 26 partials ⚠️
...estree/src/create-program/createIsolatedProgram.ts 33.33% 1 Missing and 1 partial ⚠️
...pt-estree/src/parseSettings/createParseSettings.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9852      +/-   ##
==========================================
- Coverage   86.15%   86.14%   -0.01%     
==========================================
  Files         429      429              
  Lines       15005    15005              
  Branches     4353     4353              
==========================================
- Hits        12927    12926       -1     
  Misses       1729     1729              
- Partials      349      350       +1
Flag Coverage Δ
unittest 86.14% <54.45%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/ban-ts-comment.ts 100.00% <ø> (ø)
.../eslint-plugin/src/rules/class-methods-use-this.ts 91.30% <ø> (ø)
...ackages/eslint-plugin/src/rules/member-ordering.ts 96.61% <ø> (ø)
...es/eslint-plugin/src/rules/no-invalid-void-type.ts 97.82% <ø> (ø)
...ges/eslint-plugin/src/rules/no-misused-promises.ts 97.66% <ø> (ø)
...ges/eslint-plugin/src/rules/no-restricted-types.ts 93.02% <ø> (ø)
...es/eslint-plugin/src/rules/no-use-before-define.ts 97.00% <ø> (ø)
...s/eslint-plugin/src/util/collectUnusedVariables.ts 93.72% <ø> (ø)
packages/rule-tester/src/RuleTester.ts 63.77% <ø> (ø)
...ckages/rule-tester/src/utils/flat-config-schema.ts 28.00% <ø> (ø)
... and 31 more

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 20, 2024 21:59
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team August 20, 2024 22:00
bradzacher
bradzacher previously approved these changes Aug 21, 2024
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Aug 25, 2024
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft September 2, 2024 21:13
@JoshuaKGoldberg JoshuaKGoldberg removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 11, 2024
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review October 11, 2024 14:55
@JoshuaKGoldberg
Copy link
Member Author

This was previously approved and keeps accumulating merge conflicts. I'm going to go ahead and merge it now. Someone please yell at me if there are more changes to be made. 🙂

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8d35958 into typescript-eslint:main Oct 21, 2024
59 of 62 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the perfectionist-typescript-estree branch October 21, 2024 14:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher Awaiting requested review from bradzacher

@kirkwaiblinger kirkwaiblinger Awaiting requested review from kirkwaiblinger

@rubiesonthesky rubiesonthesky Awaiting requested review from rubiesonthesky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoshuaKGoldberg @rubiesonthesky @bradzacher @kirkwaiblinger