Skip to content

chore: correct a few comment placements in utils #9856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

Overview

Fixes up a few comments that were put in an incorrect new location in #9698. Thanks @FloEdelmann for catching them!

💖

Co-authored-by: @FloEdelmann

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5f135b8
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66c5fb6b436d0900089b9fa9
😎 Deploy Preview https://deploy-preview-9856--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🔴 down 16 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Aug 21, 2024

@bradzacher
Copy link
Member

We should report these bugs upstream.

The JSDoc comments need to be attached properly during fixing so that they don't introduce breakages!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9aeba30 into typescript-eslint:main Aug 21, 2024
57 of 60 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the utils-perfectionist-comment-fixes branch August 21, 2024 23:30
@JoshuaKGoldberg
Copy link
Member Author

cc @azat-io - I added this to my personal todo to make isolated repros for, not sure when I'll be able to.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants