docs: formalized '1 approval' and 'team assigned' labels #9861
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 04e532e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>
3abac14
docs/maintenance/Pull_Requests.mdx
Outdated
| We try to wait a week on PRs to give reviewers who aren't active every day a chance to get to it. | ||
|
|
||
| :::tip | ||
| If a PR has had `1 approval` and no change requests for a week, go ahead and merge it. |
There was a problem hiding this comment.
This seems redundant? What's the purpose of this with the bullet above.
There was a problem hiding this comment.
My thought was that the instructions technically only apply if you are reviewing... but, yeah, I think anybody on the team should be able to understand this is implied. 👍
cf6da79
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9861 +/- ##
==========================================
+ Coverage 88.04% 88.05% +0.01%
==========================================
Files 407 407
Lines 13948 13947 -1
Branches 4078 4071 -7
==========================================
+ Hits 12280 12281 +1
+ Misses 1355 1354 -1
+ Partials 313 312 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
|
||
| There's no need to reset waiting periods for minor fixups from code reviews of otherwise approved code. | ||
|
|
||
| We try to leave PRs open for at least a week to give reviewers who aren't active every day a chance to get to it. |
There was a problem hiding this comment.
Made this a bit more clear/precise: it's a week in review, not a week since approval. IMO no need to wait a week after approval for something that's already been open for a bit.
There was a problem hiding this comment.
Oh, good call on clarifying that. That's a better approach than what my understanding was! 👍
PR Checklist
Overview
Summarizing scattered conversations I've had over the last few months. This PR is very much a proposal, I'm expecting some discussions in it. 😄
💖