-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: add global variable rule disabling FAQ for ESLint #9865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add global variable rule disabling FAQ for ESLint #9865
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 69dc455. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
We don't have a file for |
Maybe a concise "further reading" (or similar) link in no-namespace to this FAQ would resolve this? |
071c1b2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9865 +/- ##
==========================================
- Coverage 88.04% 88.03% -0.01%
==========================================
Files 407 407
Lines 13948 13941 -7
Branches 4078 4071 -7
==========================================
- Hits 12280 12273 -7
Misses 1355 1355
Partials 313 313
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -137,6 +137,9 @@ You might consider using [ESLint disable comments](https://eslint.org/docs/lates | |||
|
|||
## Further Reading | |||
|
|||
{/* cspell:disable-next-line */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I think you can configure cspell to ignore anchors using ignore patterns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh?? OH?? That would be so nice...
I can't find anything Googling, but if you have a reference I would very very happily send a PR to enable it & remove any now-unnecessary disables/ignores.
PR Checklist
Overview
Adds similar examples to what's in the docs issue, along with suggested remediations, tips on disable comments, and a link to the two issues.
💖