Skip to content

docs: fill in most remaining rule option descriptions #9868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 23, 2024

PR Checklist

Overview

Adds description properties to most rule options that didn't have them. This should be all remaining rules that aren't feature-frozen or using only an enum/string array (instead of object) for their options.

There are probably some rules missing that could be improved. I ran out of energy before converting most string literal union types into enums... If #9866 lands, we'll be forced to fill them in anyway.

Also standardizes the phrasing of some options to sound more like each other. Mostly, that's starting boolean options with "Whether ..." instead of some of the many more wordy ways we've used.

Another good next step after this would be #9867 IMO: using these descriptions in rule docs pages. The phrasing standardization helps with that.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 93505f5
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66c8019f37aabc0008925e78
😎 Deploy Preview https://deploy-preview-9868--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Aug 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 93505f5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg changed the title docs: fill in most remainng rule option descriptions docs: fill in most remaining rule option descriptions Aug 23, 2024
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team August 23, 2024 03:58
Comment on lines +48 to +52
/** The expected assertion style to enforce. */
assertionStyle:
| 'as'
/** The expected assertion style to enforce. */
| 'angle-bracket';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤮 formatting is ew sadly

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 23, 2024
@JoshuaKGoldberg JoshuaKGoldberg requested review from kirkwaiblinger and removed request for kirkwaiblinger August 29, 2024 18:30
@JoshuaKGoldberg JoshuaKGoldberg merged commit 5fd4251 into typescript-eslint:main Aug 29, 2024
75 of 76 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the rule-option-descriptions branch August 29, 2024 18:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add descriptions to rule schema options
2 participants