Skip to content

feat(typescript-estree): make withoutProjectParserOptions generic #9877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2024
Merged

feat(typescript-estree): make withoutProjectParserOptions generic #9877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34a261e
feat(typescript-estree): make withoutProjectParserOptions generic
JoshuaKGoldberg Aug 23, 2024
ba6ea41
Update packages/typescript-estree/src/withoutProjectParserOptions.ts
JoshuaKGoldberg Aug 24, 2024
f873dd4
Remove unnecessary import
JoshuaKGoldberg Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/typescript-estree/src/withoutProjectParserOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import type { TSESTreeOptions } from './parser-options';

/**
* Removes options that prompt the parser to parse the project with type
* information. In other words, you can use this if you are invoking the parser
Expand All @@ -8,12 +6,15 @@ import type { TSESTreeOptions } from './parser-options';
*
* @see https://github.com/typescript-eslint/typescript-eslint/issues/8428
*/
export function withoutProjectParserOptions(
opts: TSESTreeOptions,
): TSESTreeOptions {
export function withoutProjectParserOptions<Options extends object>(
opts: Options,
): Omit<
Options,
'EXPERIMENTAL_useProjectService' | 'project' | 'projectService'
> {
// eslint-disable-next-line @typescript-eslint/no-unused-vars -- The variables are meant to be omitted
const { EXPERIMENTAL_useProjectService, project, projectService, ...rest } =
opts as Record<string, unknown>;

return rest;
return rest as unknown as Options;
}
21 changes: 19 additions & 2 deletions packages/typescript-estree/tests/lib/withoutProjectParserOptions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,31 @@ import { withoutProjectParserOptions } from '../../src';

describe('withoutProjectParserOptions', () => {
it('removes only project parser options', () => {
const without = withoutProjectParserOptions({
const options = {
comment: true,
EXPERIMENTAL_useProjectService: true,
project: true,
projectService: true,
} as TSESTreeOptions);
} as TSESTreeOptions;

const without = withoutProjectParserOptions(options);

expect(without).toEqual({
comment: true,
});
});

it('allows an alternate type extending from TSESTreeOptions', () => {
const without = withoutProjectParserOptions({
comment: true,
project: true,
projectService: true,
other: true,
});

expect(without).toEqual({
comment: true,
other: true,
});
});
});
Loading