Skip to content

chore: disable eslint-plugin-perfectionist on enums #9883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

chore: disable eslint-plugin-perfectionist on enums #9883

merged 1 commit into from
Aug 30, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

As per the comment, completely disables sorting on enums. We tend to use them in ways where our own ordering makes more sense than alphabetical/natural.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 25, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2239927
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66cb5b85dce20b00084b081e
😎 Deploy Preview https://deploy-preview-9883--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: disable eslint-plugin-perfectionist n enums chore: disable eslint-plugin-perfectionist on enums Aug 25, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 25, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2239927. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team August 25, 2024 16:54
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 27, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit cc50e62 into typescript-eslint:main Aug 30, 2024
66 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the perfectionist-no-enums branch August 30, 2024 12:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaKGoldberg @bradzacher @kirkwaiblinger