-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: declare TypeScript as an optional peerDependency #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @dstaley! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Thanks for opening this. We were planning on doing this ourselves, but we wanted to wait until the fix landed and was well rolled out within |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rc
@dstaley @bradzacher Can you at least add the |
That's awesome! I didn't know that it did that. or alternately, happy if @dstaley modifies this PR to remove the explicit |
@bradzacher explicit dependencies have been removed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
Awesome, thank you both! 🥳 |
FYI - we missed the release by a bit, so this will officially release next monday. |
This PR adds TypeScript as an optional peer dependency for
@typescript-eslint/eslint-plugin
. This modification is necessary to get@typescript-eslint/eslint-plugin
working with Yarn v2, and is one of two packages that need this modification so that the TypeScript version ofcreate-react-app
can work with Yarn v2.Optional peer dependencies work as expected in Yarn and pnpm, and will be supported in npm once a server-side fix is deployed.
Other relevant issues: yarnpkg/berry/pull/475