Skip to content

feat(eslint-plugin): [no-unsafe-argument] differentiate error types #9920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2024
Merged

feat(eslint-plugin): [no-unsafe-argument] differentiate error types #9920

merged 3 commits into from
Sep 9, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Uses the same "error typed" phrasing as other no-unsafe-* rules.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Sep 3, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0262c0c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66de39fdca2baf0008a3bc4a
😎 Deploy Preview https://deploy-preview-9920--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 3, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0262c0c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

bradzacher
bradzacher previously approved these changes Sep 3, 2024
View reviewed changes
@JoshuaKGoldberg @bradzacher
Update packages/eslint-plugin/src/rules/no-unsafe-argument.ts
00160e3 
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 3, 2024
kirkwaiblinger
kirkwaiblinger previously approved these changes Sep 8, 2024
View reviewed changes
JoshuaKGoldberg
JoshuaKGoldberg commented Sep 9, 2024
View reviewed changes
packages/eslint-plugin/tests/docs-eslint-output-snapshots/no-unsafe-argument.shot
@@ -14,16 +14,15 @@ foo(anyTyped, 1, 'a');

const anyArray: any[] = [];
foo(...anyArray);
~~~~~~~~~~~ Unsafe spread of an \`any\` array type.
~~~~~~~~~~~ Unsafe spread of an \`any[]\` array type.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice little output improvement / fix. 😎

@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.05%. Comparing base (5d9f49c) to head (0262c0c).
Report is 17 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9920      +/-   ##
==========================================
- Coverage   88.12%   86.05%   -2.08%     
==========================================
  Files         406      425      +19     
  Lines       13951    14804     +853     
  Branches     4076     4306     +230     
==========================================
+ Hits        12294    12739     +445     
- Misses       1344     1718     +374     
- Partials      313      347      +34
Flag Coverage Δ
unittest 86.05% <100.00%> (-2.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts 90.21% <100.00%> (+1.32%) ⬆️

... and 27 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg merged commit c49b91f into typescript-eslint:main Sep 9, 2024
61 of 62 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-unsafe-argument-error-type-message branch September 9, 2024 00:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

@kirkwaiblinger kirkwaiblinger kirkwaiblinger left review comments

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unsafe-argument] Differentiate a types-error any from a "true" any
3 participants
@JoshuaKGoldberg @bradzacher @kirkwaiblinger