feat(eslint-plugin): [prefer-nullish-coalescing] add option `ignoreBooleanCoercion` #9924

developer-bandi · 2024-09-03T14:35:41Z

PR Checklist

Addresses an existing open issue:
- fixes Enhancement: [prefer-nullish-coalescing] should ignore Boolean constructor #9080
- fixes Bug: [prefer-nullish-coalescing] faulty detection of conditional tests with ignoreConditionalTests: true #10153
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

I read the comments on the issue, and it seemed better to create a new option rather than adding a function to ignoreConditionalTests, so I created a new option.

The reason is that I thought it was reasonable to say that there is no case in typescript-eslint where the content raised in the issue is judged as a condition/boolean.

typescript-eslint · 2024-09-03T14:35:45Z

Thanks for the PR, @developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-09-03T14:35:55Z

❌ Deploy Preview for typescript-eslint failed.

Name	Link
🔨 Latest commit	`52c3596`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6725acfab9448f0008c7480a

nx-cloud · 2024-09-03T14:36:50Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 52c3596. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

codecov · 2024-09-04T13:56:50Z

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.51%. Comparing base (099fd4c) to head (52c3596).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	88.57%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9924      +/-   ##
==========================================
- Coverage   86.51%   86.51%   -0.01%     
==========================================
  Files         430      430              
  Lines       15098    15123      +25     
  Branches     4384     4400      +16     
==========================================
+ Hits        13062    13083      +21     
- Misses       1679     1683       +4     
  Partials      357      357

Flag	Coverage Δ
unittest	`86.51% <88.57%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	`95.51% <88.57%> (-2.20%)`	⬇️

JoshuaKGoldberg · 2024-09-30T12:53:48Z

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts

+      (current.type === AST_NODE_TYPES.CallExpression &&
+        current.callee.type === AST_NODE_TYPES.Identifier &&
+        // eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
+        current.callee.name === 'Boolean')


[Bug] Folks sometimes write their own function Boolean( ... ) { ... }. This rule will need to handle that well.

Previous example: #10005 (comment)

thank you. I modified it by referring to the code written by @yeonjuan .

JoshuaKGoldberg · 2024-09-30T12:54:05Z

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts

+       * `if (() => a || b) {}`
+       * `if (function () { return a || b }) {}`
+       */
+      return false;


[Testing] Good to see that the cases tripping this up are known 😄.

Also to test are other unusual things in ifs:

class expressions

new expressions

Function decorators

...I'm drawing a blank on more spooky things at the moment, but there's a good chance more exist.

Because I was copying the isConditionalTest function, I forgot to change the example case. In practice, an example would be Boolean(()=> a || b).
Therefore, it seems that the situations you mentioned should actually apply to the isConditionalTest function as well. Should the work be done in this pr?

Actually, I did not exactly understand the three cases you mentioned. Could you please give an example if possible?

The additional case I was considering is an object. Should cases like Boolean({test:a||b}) also be included?

JoshuaKGoldberg

Hey sorry for the long wait! This is a good start, but I think has some edge case handling and testing to go. 🚀

JoshuaKGoldberg · 2024-09-30T12:55:22Z

packages/eslint-plugin/docs/rules/prefer-nullish-coalescing.mdx

@@ -172,6 +172,34 @@ foo ?? 'a string';

 Also, if you would like to ignore all primitives types, you can set `ignorePrimitives: true`. It is equivalent to `ignorePrimitives: { string: true, number: true, bigint: true, boolean: true }`.

+### `ignoreMakeBoolean`


[Docs] "make" is a general word. Let's go with ignoreBooleanCoercion:

Suggested change

### `ignoreMakeBoolean`

### `ignoreBooleanCoercion`

JoshuaKGoldberg · 2024-09-30T12:55:55Z

packages/eslint-plugin/docs/rules/prefer-nullish-coalescing.mdx

+Whether to ignore any make boolean type value like `Boolan`, `!` .
+
+like !, Boolean, etc. You can use this when you do not want to apply the rule to cases that make the value a boolean.


Suggested change

Whether to ignore any make boolean type value like `Boolan`, `!` .

like !, Boolean, etc. You can use this when you do not want to apply the rule to cases that make the value a boolean.

Whether to ignore expressions that coerce a value into a boolean: `Boolean(...)` and `!(...)`.

kirkwaiblinger

Why does this option include allowing arguments to the ! operator? The discussion in the issue explicitly contradicts this #9080 (comment)

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts

developer-bandi · 2024-10-10T12:51:29Z

이 옵션에 !연산자에 대한 인수 허용이 포함되는 이유는 무엇입니까? 이 이슈의 논의는 이 #9080(코멘트) 과 명백히 모순됩니다.

This is clearly my mistake.

I misunderstood that the Not operator should be included in the process of understanding the context.

I will remove all related code and test code.

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts

kirkwaiblinger · 2024-10-10T15:10:58Z

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts

+function isMakeBoolean(
+  node: TSESTree.Node,
+  context: Readonly<TSESLint.RuleContext<MessageIds, Options>>,
+): boolean {
+  const parents = new Set<TSESTree.Node | null>([node]);
+  let current = node.parent;
+  while (current) {
+    parents.add(current);
+
+    if (
+      current.type === AST_NODE_TYPES.CallExpression &&
+      isBuiltInBooleanCall(current, context)
+    ) {
+      return true;
+    }
+


So, the algorithm in this function definitely has some problems....

For example, the following code will be ignored by the new option

let a: string | true | undefined; let b: string | boolean | undefined; declare function f(x: unknown): unknown; const x = Boolean(f(a || b));

However, I'm also noticing that the existing code works quite similarly....

typescript-eslint/packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts

Lines 414 to 449 in 723d0a8

function isConditionalTest(node: TSESTree.Node): boolean {

const parents = new Set<TSESTree.Node | null>([node]);

let current = node.parent;

while (current) {

parents.add(current);

if (

(current.type === AST_NODE_TYPES.ConditionalExpression ||

current.type === AST_NODE_TYPES.DoWhileStatement ||

current.type === AST_NODE_TYPES.IfStatement ||

current.type === AST_NODE_TYPES.ForStatement ||

current.type === AST_NODE_TYPES.WhileStatement) &&

parents.has(current.test)

) {

return true;

}

if (

[

AST_NODE_TYPES.ArrowFunctionExpression,

AST_NODE_TYPES.FunctionExpression,

].includes(current.type)

) {

/**

* This is a weird situation like:

* `if (() => a || b) {}`

* `if (function () { return a || b }) {}`

*/

return false;

}

current = current.parent;

}

return false;

}

So I'm wondering whether that has bugs too....

Without that context, I'd think we'd want to model this algorithm closer to what's in other rules, for example, no-floating-promises or no-extra-boolean-cast. Those rules recurse specifically on logical expressions, ?? expressions, ternaries, chain expressions, sequence expressions.

upon checking, it appears that similar code is ignored when the ignoreConditionalTests option is true playground

declare let a: string | null; declare const b: string | null; declare function f(x: unknown): unknown; if (f(a || b)) {} while (f(a || b)) {}

so i think isConditionalTest function need to modified. Would it be a good idea to open a new issue for this problem?

to modify algorithm, I looked at the no-extra-boolean-cast code you mentioned.

considering what you mentioned, it seems like you can improve it by referring to the algorithm of the function below, but I am wondering if my understanding is correct.

https://github.com/eslint/eslint/blob/main/lib/rules/no-extra-boolean-cast.js#L117-L167

What fun, haha. Thanks for checking on this!

I think file an issue no matter what, and it's up to you if you feel motivated and want to fix it in this PR or prefer to not worry about it in this work. 👍

considering what you mentioned, it seems like you can improve it by referring to the algorithm of the function below, but I am wondering if my understanding is correct.

Yeah, exactly, that's the pattern I'm suggesting to study 👍 (just the first thing that came to my mind, since I have previously touched that code)

What fun, haha. Thanks for checking on this!

I think file an issue no matter what, and it's up to you if you feel motivated and want to fix it in this PR or
prefer to not worry about it in this work. 👍

It is assumed that similar logic will be used in isConditionalTest Fn, so �i will work on it together in this PR.

considering what you mentioned, it seems like you can improve it by referring to the algorithm of the function below, but I am wondering if my understanding is correct.

Yeah, exactly, that's the pattern I'm suggesting to study 👍 (just the first thing that came to my mind, since I have previously touched that code)

thank you, I will look at the code in more detail and then proceed with the work.

developer-bandi · 2024-10-20T12:10:30Z

i edit the isConditionalTest and isBooleanConstructorContext with no-extra-boolean-cast rule's code.

These functions have been modified in almost the same way, changing from recursively searching if a parent exists to recursively searching only if the logical operation conditions are satisfied.

The logical operation conditions are the same for both functions, but recursive search is allowed only when the result of the logical operation is used as the value.

recursive is not allowed

if(f(a||b))
if(()=>a||b)
if((a||b)?.[c])
....

**recursive is allowed **

if (a || (b && c)) {}
if (a ?? (b || c)) {}
...

For more examples, please refer to the test code.

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts

kirkwaiblinger

Thanks for going above and beyond by fixing issues in the existing code in addition to the added functionality!

kirkwaiblinger · 2024-10-23T23:23:02Z

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts

@@ -103,6 +104,11 @@ export default createRule<Options, MessageIds>({
              'Whether to ignore any ternary expressions that could be simplified by using the nullish coalescing operator.',
            type: 'boolean',
          },
+          ignoreBooleanCoercion: {
+            description:
+              'Whether to ignore any make boolean type value like `Boolean`',


Suggested change

'Whether to ignore any make boolean type value like `Boolean`',

'Whether to ignore arguments to the `Boolean` constructor',

…eslint into feature/prefer-nullish-coalescing

developer-bandi · 2024-11-02T06:19:52Z

added commit to resolve conflicts.

bradzacher

thanks!

@auvred

##### [v8.13.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8130-2024-11-04) ##### 🚀 Features - **eslint-plugin:** \[only-throw-error] add allow option ([#10221](typescript-eslint/typescript-eslint#10221)) - **eslint-plugin:** \[prefer-nullish-coalescing] add option `ignoreBooleanCoercion` ([#9924](typescript-eslint/typescript-eslint#9924)) - **eslint-plugin:** disable `no-class-assign` rule in `eslint-recommended` config ([#10250](typescript-eslint/typescript-eslint#10250)) ##### 🩹 Fixes - **eslint-plugin:** \[switch-exhaustiveness-check] add support for covering a missing property with `undefined` ([#10232](typescript-eslint/typescript-eslint#10232)) - **eslint-plugin:** \[consistent-type-definitions] don't leave trailing parens when fixing type to interface ([#10235](typescript-eslint/typescript-eslint#10235)) - **eslint-plugin:** \[no-deprecated] report when exported class implements/extends deprecated entity ([#10259](typescript-eslint/typescript-eslint#10259)) - **eslint-plugin:** \[no-deprecated] report on deprecated variables used inside dynamic imports ([#10261](typescript-eslint/typescript-eslint#10261)) - **eslint-plugin:** \[no-unnecessary-condition] falsey bigint should be falsey ([#10205](typescript-eslint/typescript-eslint#10205)) ##### ❤️ Thank You - auvred [@auvred](https://github.com/auvred) - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast) - Ronen Amiel - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@auvred

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.12.2 | 8.13.0 | | npm | @typescript-eslint/parser | 8.12.2 | 8.13.0 | ## [v8.13.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8130-2024-11-04) ##### 🚀 Features - **eslint-plugin:** \[only-throw-error] add allow option ([#10221](typescript-eslint/typescript-eslint#10221)) - **eslint-plugin:** \[prefer-nullish-coalescing] add option `ignoreBooleanCoercion` ([#9924](typescript-eslint/typescript-eslint#9924)) - **eslint-plugin:** disable `no-class-assign` rule in `eslint-recommended` config ([#10250](typescript-eslint/typescript-eslint#10250)) ##### 🩹 Fixes - **eslint-plugin:** \[switch-exhaustiveness-check] add support for covering a missing property with `undefined` ([#10232](typescript-eslint/typescript-eslint#10232)) - **eslint-plugin:** \[consistent-type-definitions] don't leave trailing parens when fixing type to interface ([#10235](typescript-eslint/typescript-eslint#10235)) - **eslint-plugin:** \[no-deprecated] report when exported class implements/extends deprecated entity ([#10259](typescript-eslint/typescript-eslint#10259)) - **eslint-plugin:** \[no-deprecated] report on deprecated variables used inside dynamic imports ([#10261](typescript-eslint/typescript-eslint#10261)) - **eslint-plugin:** \[no-unnecessary-condition] falsey bigint should be falsey ([#10205](typescript-eslint/typescript-eslint#10205)) ##### ❤️ Thank You - auvred [@auvred](https://github.com/auvred) - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast) - Ronen Amiel - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@auvred

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.12.2 | 8.13.0 | | npm | @typescript-eslint/parser | 8.12.2 | 8.13.0 | ## [v8.13.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8130-2024-11-04) ##### 🚀 Features - **eslint-plugin:** \[only-throw-error] add allow option ([#10221](typescript-eslint/typescript-eslint#10221)) - **eslint-plugin:** \[prefer-nullish-coalescing] add option `ignoreBooleanCoercion` ([#9924](typescript-eslint/typescript-eslint#9924)) - **eslint-plugin:** disable `no-class-assign` rule in `eslint-recommended` config ([#10250](typescript-eslint/typescript-eslint#10250)) ##### 🩹 Fixes - **eslint-plugin:** \[switch-exhaustiveness-check] add support for covering a missing property with `undefined` ([#10232](typescript-eslint/typescript-eslint#10232)) - **eslint-plugin:** \[consistent-type-definitions] don't leave trailing parens when fixing type to interface ([#10235](typescript-eslint/typescript-eslint#10235)) - **eslint-plugin:** \[no-deprecated] report when exported class implements/extends deprecated entity ([#10259](typescript-eslint/typescript-eslint#10259)) - **eslint-plugin:** \[no-deprecated] report on deprecated variables used inside dynamic imports ([#10261](typescript-eslint/typescript-eslint#10261)) - **eslint-plugin:** \[no-unnecessary-condition] falsey bigint should be falsey ([#10205](typescript-eslint/typescript-eslint#10205)) ##### ❤️ Thank You - auvred [@auvred](https://github.com/auvred) - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast) - Ronen Amiel - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

feat: make new option

aa7545b

fix: test error

029f64e

fix: lint error

ce4df82

JoshuaKGoldberg reviewed Sep 30, 2024

View reviewed changes

JoshuaKGoldberg requested changes Sep 30, 2024

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Sep 30, 2024

fix: apply code review

9e11e22

developer-bandi requested a review from JoshuaKGoldberg October 3, 2024 14:53

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 3, 2024

kirkwaiblinger requested changes Oct 9, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts Outdated Show resolved Hide resolved

kirkwaiblinger added the awaiting response Issues waiting for a reply from the OP or another party label Oct 9, 2024

developer-bandi added 2 commits October 10, 2024 22:03

fix: typo correction

15ac922

fix: remove not operator logic

723d0a8

developer-bandi requested a review from kirkwaiblinger October 10, 2024 13:40

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 10, 2024

kirkwaiblinger requested changes Oct 10, 2024

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Oct 10, 2024

fix: apply code review

d5f780f

developer-bandi requested a review from kirkwaiblinger October 14, 2024 18:22

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 14, 2024

kirkwaiblinger mentioned this pull request Oct 15, 2024

Bug: [prefer-nullish-coalescing] faulty detection of conditional tests with ignoreConditionalTests: true #10153

Closed

4 tasks

change logical logic

a46d2af

kirkwaiblinger changed the title ~~feat(eslint-plugin): [prefer-nullish-coalescing] make ignore Boolean like option~~ feat(eslint-plugin): [prefer-nullish-coalescing] add option ignoreBooleanCoercion Oct 20, 2024

kirkwaiblinger reviewed Oct 21, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts Outdated Show resolved Hide resolved

refactor: fix isBooleanConstructorContext and isConditionalTest fn

dfcc469

developer-bandi requested a review from kirkwaiblinger October 22, 2024 14:49

kirkwaiblinger previously approved these changes Oct 23, 2024

View reviewed changes

kirkwaiblinger reviewed Oct 23, 2024

View reviewed changes

fix:docs{

9d8c4e4

developer-bandi dismissed kirkwaiblinger’s stale review via 9d8c4e4 October 27, 2024 06:58

kirkwaiblinger added 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels Oct 27, 2024

developer-bandi added 4 commits November 2, 2024 11:31

Merge branch 'main' of https://github.com/developer-bandi/typescript-…

99df843

…eslint into feature/prefer-nullish-coalescing

fix: merge confict miss add

f59d7cc

fix: lint error

f738414

fix: snapshot update

52c3596

kirkwaiblinger approved these changes Nov 2, 2024

View reviewed changes

kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 2, 2024

bradzacher approved these changes Nov 3, 2024

View reviewed changes

bradzacher merged commit be3a224 into typescript-eslint:main Nov 3, 2024
59 of 64 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): [prefer-nullish-coalescing] add option `ignoreBooleanCoercion` #9924

feat(eslint-plugin): [prefer-nullish-coalescing] add option `ignoreBooleanCoercion` #9924

developer-bandi commented Sep 3, 2024 •

edited by kirkwaiblinger

Loading

typescript-eslint bot commented Sep 3, 2024

netlify bot commented Sep 3, 2024 •

edited

Loading

nx-cloud bot commented Sep 3, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024 •

edited

Loading

JoshuaKGoldberg Sep 30, 2024

developer-bandi Oct 3, 2024

JoshuaKGoldberg Sep 30, 2024

developer-bandi Oct 3, 2024

JoshuaKGoldberg left a comment

JoshuaKGoldberg Sep 30, 2024

JoshuaKGoldberg Sep 30, 2024

kirkwaiblinger left a comment

developer-bandi commented Oct 10, 2024

kirkwaiblinger Oct 10, 2024

developer-bandi Oct 14, 2024 •

edited by kirkwaiblinger

Loading

kirkwaiblinger Oct 14, 2024 •

edited

Loading

kirkwaiblinger Oct 14, 2024

developer-bandi Oct 15, 2024 •

edited

Loading

developer-bandi Oct 15, 2024 •

edited

Loading

developer-bandi commented Oct 20, 2024

kirkwaiblinger left a comment

kirkwaiblinger Oct 23, 2024

developer-bandi commented Nov 2, 2024

bradzacher left a comment

		@@ -172,6 +172,34 @@ foo ?? 'a string';

		Also, if you would like to ignore all primitives types, you can set `ignorePrimitives: true`. It is equivalent to `ignorePrimitives: { string: true, number: true, bigint: true, boolean: true }`.

		### `ignoreMakeBoolean`

		Whether to ignore any make boolean type value like `Boolan`, `!` .

		like !, Boolean, etc. You can use this when you do not want to apply the rule to cases that make the value a boolean.

	function isConditionalTest(node: TSESTree.Node): boolean {
	const parents = new Set<TSESTree.Node \| null>([node]);
	let current = node.parent;
	while (current) {
	parents.add(current);

	if (
	(current.type === AST_NODE_TYPES.ConditionalExpression \|\|
	current.type === AST_NODE_TYPES.DoWhileStatement \|\|
	current.type === AST_NODE_TYPES.IfStatement \|\|
	current.type === AST_NODE_TYPES.ForStatement \|\|
	current.type === AST_NODE_TYPES.WhileStatement) &&
	parents.has(current.test)
	) {
	return true;
	}

	if (
	[
	AST_NODE_TYPES.ArrowFunctionExpression,
	AST_NODE_TYPES.FunctionExpression,
	].includes(current.type)
	) {
	/**
	* This is a weird situation like:
	* `if (() => a \|\| b) {}`
	* `if (function () { return a \|\| b }) {}`
	*/
	return false;
	}

	current = current.parent;
	}

	return false;
	}

	'Whether to ignore any make boolean type value like `Boolean`',
	'Whether to ignore arguments to the `Boolean` constructor',

feat(eslint-plugin): [prefer-nullish-coalescing] add option ignoreBooleanCoercion #9924

feat(eslint-plugin): [prefer-nullish-coalescing] add option ignoreBooleanCoercion #9924

Conversation

developer-bandi commented Sep 3, 2024 • edited by kirkwaiblinger Loading

PR Checklist

Overview

typescript-eslint bot commented Sep 3, 2024

netlify bot commented Sep 3, 2024 • edited Loading

❌ Deploy Preview for typescript-eslint failed.

nx-cloud bot commented Sep 3, 2024 • edited Loading

☁️ Nx Cloud Report

codecov bot commented Sep 4, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kirkwaiblinger left a comment

Choose a reason for hiding this comment

developer-bandi commented Oct 10, 2024

Choose a reason for hiding this comment

developer-bandi Oct 14, 2024 • edited by kirkwaiblinger Loading

Choose a reason for hiding this comment

kirkwaiblinger Oct 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

developer-bandi Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

developer-bandi Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

developer-bandi commented Oct 20, 2024

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

developer-bandi commented Nov 2, 2024

bradzacher left a comment

Choose a reason for hiding this comment

feat(eslint-plugin): [prefer-nullish-coalescing] add option `ignoreBooleanCoercion` #9924

feat(eslint-plugin): [prefer-nullish-coalescing] add option `ignoreBooleanCoercion` #9924

developer-bandi commented Sep 3, 2024 •

edited by kirkwaiblinger

Loading

netlify bot commented Sep 3, 2024 •

edited

Loading

nx-cloud bot commented Sep 3, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024 •

edited

Loading

developer-bandi Oct 14, 2024 •

edited by kirkwaiblinger

Loading

kirkwaiblinger Oct 14, 2024 •

edited

Loading

developer-bandi Oct 15, 2024 •

edited

Loading

developer-bandi Oct 15, 2024 •

edited

Loading