feat(eslint-plugin): [switch-exhaustiveness-check] add considerDefaultExhaustiveForUnions option #9954

developer-bandi · 2024-09-08T06:30:05Z

PR Checklist

Addresses an existing open issue: fixes Enhancement: [switch-exhaustiveness-check] Add ability to ignore default case #8247
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

add considerDefaultExhaustiveForUnions option to dismiss default case when decide exhaustiveness
In this situation, even if there is a default case, an error must be added to the key that does not exist, so we changed some of the code modification logic.

typescript-eslint · 2024-09-08T06:30:08Z

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-09-08T06:30:20Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`76c8716`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/671e5622186e610008fce626
😎 Deploy Preview	https://deploy-preview-9954--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 5 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-09-08T06:31:01Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 76c8716. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 28 targets

Sent with 💌 from NxCloud.

codecov · 2024-09-08T06:39:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.19%. Comparing base (74ace4d) to head (76c8716).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9954   +/-   ##
=======================================
  Coverage   86.19%   86.19%           
=======================================
  Files         430      430           
  Lines       15064    15071    +7     
  Branches     4371     4373    +2     
=======================================
+ Hits        12984    12991    +7     
  Misses       1728     1728           
  Partials      352      352

Flag	Coverage Δ
unittest	`86.19% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...nt-plugin/src/rules/switch-exhaustiveness-check.ts	`98.78% <100.00%> (+0.11%)`	⬆️

JoshuaKGoldberg

🆒

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx

packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx

packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts

packages/eslint-plugin/tests/rules/switch-exhaustiveness-check.test.ts

kirkwaiblinger

The code logic looks great to me, but some cleanup is needed for the option naming and docs.

allowDefaultCaseMatchUnionMember is ungrammatical, and requireDefaultCaseForUnions is not accurate, to my understanding.

Maybe requireExplicitCasesForUnion or considerDefaultExhaustiveForUnion depending on which direction the true/false goes?

kirkwaiblinger · 2024-10-09T18:53:21Z

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx

@@ -53,6 +53,29 @@ switch (value) {

 Since `value` is a non-union type it requires the switch case to have a default clause only with `requireDefaultForNonUnion` enabled.

+### `allowDefaultCaseMatchUnionMember`


option name in docs differs from code

kirkwaiblinger · 2024-10-09T19:00:22Z

packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts

@@ -155,10 +173,13 @@ export default createRule<Options, MessageIds>({
      const { missingLiteralBranchTypes, symbolName, defaultCase } =
        switchMetadata;

-      // We only trigger the rule if a `default` case does not exist, since that
-      // would disqualify the switch statement from having cases that exactly
+      // We only trigger the rule if a `default` case does not exist when requireDefaultCaseForUnions option


(clarity nit)

Maybe just have a standalone condition like

// Unless requireDefaultCaseForUnions is enabled, the presence of a default case // always makes the switch exhaustive. if (!requireDefaultCaseForUnions && defaultCase != null) { return; }

kirkwaiblinger · 2024-10-09T19:11:35Z

packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts

@@ -243,6 +264,15 @@ export default createRule<Options, MessageIds>({
        .join('\n');

      if (lastCase) {
+        const isLastCaseDefaultCase = lastCase.test == null;
+        if (isLastCaseDefaultCase) {


(optional)

food for thought - what if the default case isn't the last case?

This change makes it so that we avoid suggesting to fix

declare const literal: 'a' | 'b'; switch (literal) { case 'b': default: }

to

declare const literal: 'a' | 'b'; switch (literal) { case 'b': default: case "a": { throw new Error('Not implemented yet: "a" case') } }

and instead fix it to

declare const literal: 'a' | 'b'; switch (literal) { case 'b': case "a": { throw new Error('Not implemented yet: "a" case') } default: }

. (also note that this has its own issue of no longer having case 'b' be handled the same as default, instead having it throw as not implemented yet).

But it will happily fix

declare const literal: 'a' | 'b'; switch (literal) { default: case 'b': }

to

declare const literal: 'a' | 'b'; switch (literal) { default: case 'b': case "a": { throw new Error('Not implemented yet: "a" case') } }

which still has the added case as part of the default 🤔, even though the first examples implies this code is trying to avoid it. Maybe to be more consistent we could say "if default case is present, add it above it, else add it at the end"?

I don't think that this is super important since the user will have to do manual cleanup regardless, but just throwing this out there in case you want to tweak some edge cases. I'm ok with either way though.

kirkwaiblinger · 2024-10-09T19:18:16Z

packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts

@@ -65,6 +72,10 @@ export default createRule<Options, MessageIds>({
            description: `If 'true', require a 'default' clause for switches on non-union types.`,
            type: 'boolean',
          },
+          requireDefaultCaseForUnions: {
+            description: `If 'true', the 'default' clause is used to determine whether the switch statement is Exhaustive for union type`,


Suggested change

description: `If 'true', the 'default' clause is used to determine whether the switch statement is Exhaustive for union type`,

description: `If 'true', the 'default' clause is used to determine whether the switch statement is exhaustive for union type`,

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx

kirkwaiblinger · 2024-10-09T19:41:49Z

(Further thoughts on naming and options) -

My understanding is that there are two independent things going on with union types and defaults.

When all union constituents do have their own explicit case, whether a default case is prohibited|ignored|required. This is currently controlled by the existing allowDefaultCaseForExhaustiveSwitch option, and the only possibilities currently supported by this rule are prohibited|ignored (If you want the "required" behavior you can use the separate rule default-case).
When some union constituents do not have their own explicit case, whether a default case will silence the rule. This is the new option being created.

Perhaps thinking about it in this framework can help clarify the docs and the naming.

When I read requireDefaultCaseForUnions, that describes the behavior in 1., not in 2.

developer-bandi · 2024-10-10T15:09:37Z

As for the option name, the considerDefaultExhaustiveForUnion you suggested looks good.

It seems that including both Default and Exhaustive keywords is more appropriate in the context you explained.

Once the option name is decided, related modifications will be reflected.

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx

kirkwaiblinger · 2024-10-14T21:54:46Z

looks pretty close. Let's just change the option name to considerDefaultExhaustiveForUnions and if anyone else has a conflicting opinion they can object before it gets merged 👍

Remove unnecessary phrases

kirkwaiblinger · 2024-10-15T16:03:03Z

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx

+
+Defaults to false. Whether a `default` clause will be considered as making a switch statement over a union type exhaustive.
+
+By default, if a `switch` statement over a union type includes a `default` case, then it's considered exhaustive.


this is the opposite way (since the option defaults to false). By default, every branch will be required to be explicitly handled, and one may opt out by enabling considerDefaultExhaustiveForUnions

thank you I think I missed changing it at the same time when changing the default value.

kirkwaiblinger

Just the nit in https://github.com/typescript-eslint/typescript-eslint/pull/9954/files#r1801500418

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx

kirkwaiblinger

Good stuff! I'm super excited to get this change released! This has been a pain point for me as a user of the rule, and I'm glad to see it addressed 🙂

FYI - I've made a few edits to your branch primarily in order to get the website to build (we added in the {/* insert option description */} thing recently, which prevented the CI from building).

stale

JoshuaKGoldberg

LGTM :)

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx

@developer-bandi

##### [v8.12.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8120-2024-10-28) ##### 🚀 Features - **eslint-plugin:** \[no-base-to-string] handle String() ([#10005](typescript-eslint/typescript-eslint#10005)) - **eslint-plugin:** \[switch-exhaustiveness-check] add allowDefaultCaseMatchUnionMember option ([#9954](typescript-eslint/typescript-eslint#9954)) - **eslint-plugin:** \[consistent-indexed-object-style] report mapped types ([#10160](typescript-eslint/typescript-eslint#10160)) - **eslint-plugin:** \[prefer-nullish-coalescing] add support for assignment expressions ([#10152](typescript-eslint/typescript-eslint#10152)) ##### ❤️ Thank You - Abraham Guo - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@kirkwaiblinger

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.11.0 | 8.12.2 | | npm | @typescript-eslint/parser | 8.11.0 | 8.12.2 | ## [v8.12.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8122-2024-10-29) ##### 🩹 Fixes - **eslint-plugin:** \[switch-exhaustiveness-check] invert `considerDefaultExhaustiveForUnions` ([#10223](typescript-eslint/typescript-eslint#10223)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.12.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8121-2024-10-28) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.12.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8120-2024-10-28) ##### 🚀 Features - **eslint-plugin:** \[no-base-to-string] handle String() ([#10005](typescript-eslint/typescript-eslint#10005)) - **eslint-plugin:** \[switch-exhaustiveness-check] add allowDefaultCaseMatchUnionMember option ([#9954](typescript-eslint/typescript-eslint#9954)) - **eslint-plugin:** \[consistent-indexed-object-style] report mapped types ([#10160](typescript-eslint/typescript-eslint#10160)) - **eslint-plugin:** \[prefer-nullish-coalescing] add support for assignment expressions ([#10152](typescript-eslint/typescript-eslint#10152)) ##### ❤️ Thank You - Abraham Guo - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@kirkwaiblinger

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.11.0 | 8.12.2 | | npm | @typescript-eslint/parser | 8.11.0 | 8.12.2 | ## [v8.12.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8122-2024-10-29) ##### 🩹 Fixes - **eslint-plugin:** \[switch-exhaustiveness-check] invert `considerDefaultExhaustiveForUnions` ([#10223](typescript-eslint/typescript-eslint#10223)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.12.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8121-2024-10-28) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.12.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8120-2024-10-28) ##### 🚀 Features - **eslint-plugin:** \[no-base-to-string] handle String() ([#10005](typescript-eslint/typescript-eslint#10005)) - **eslint-plugin:** \[switch-exhaustiveness-check] add allowDefaultCaseMatchUnionMember option ([#9954](typescript-eslint/typescript-eslint#9954)) - **eslint-plugin:** \[consistent-indexed-object-style] report mapped types ([#10160](typescript-eslint/typescript-eslint#10160)) - **eslint-plugin:** \[prefer-nullish-coalescing] add support for assignment expressions ([#10152](typescript-eslint/typescript-eslint#10152)) ##### ❤️ Thank You - Abraham Guo - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@kirkwaiblinger

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.11.0 | 8.12.2 | | npm | @typescript-eslint/parser | 8.11.0 | 8.12.2 | ## [v8.12.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8122-2024-10-29) ##### 🩹 Fixes - **eslint-plugin:** \[switch-exhaustiveness-check] invert `considerDefaultExhaustiveForUnions` ([#10223](typescript-eslint/typescript-eslint#10223)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.12.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8121-2024-10-28) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. ## [v8.12.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8120-2024-10-28) ##### 🚀 Features - **eslint-plugin:** \[no-base-to-string] handle String() ([#10005](typescript-eslint/typescript-eslint#10005)) - **eslint-plugin:** \[switch-exhaustiveness-check] add allowDefaultCaseMatchUnionMember option ([#9954](typescript-eslint/typescript-eslint#9954)) - **eslint-plugin:** \[consistent-indexed-object-style] report mapped types ([#10160](typescript-eslint/typescript-eslint#10160)) - **eslint-plugin:** \[prefer-nullish-coalescing] add support for assignment expressions ([#10152](typescript-eslint/typescript-eslint#10152)) ##### ❤️ Thank You - Abraham Guo - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

feat: add option

6d0448b

developer-bandi changed the title ~~feat(eslint-plugin):[switch-exhaustiveness-check] add allowDefaultCaseMatchUnionMember option~~ feat(eslint-plugin): [switch-exhaustiveness-check] add allowDefaultCaseMatchUnionMember option Sep 8, 2024

developer-bandi added 2 commits September 8, 2024 23:56

fix: test error

82f7a10

fix: lint error

5ac803c

JoshuaKGoldberg previously requested changes Sep 30, 2024

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Sep 30, 2024

fix: apply code reivew

fb1406a

developer-bandi requested a review from JoshuaKGoldberg October 3, 2024 12:17

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 3, 2024

kirkwaiblinger reviewed Oct 9, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx Show resolved Hide resolved

kirkwaiblinger added awaiting response Issues waiting for a reply from the OP or another party enhancement New feature or request labels Oct 9, 2024

fix: reflect code review

bef9823

developer-bandi requested a review from kirkwaiblinger October 10, 2024 16:37

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 10, 2024

kirkwaiblinger reviewed Oct 14, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx Outdated Show resolved Hide resolved

developer-bandi added 2 commits October 15, 2024 22:49

docs:

c76867c

Remove unnecessary phrases

docs: change option name

e0c892e

kirkwaiblinger reviewed Oct 15, 2024

View reviewed changes

kirkwaiblinger requested changes Oct 15, 2024

View reviewed changes

docs: considerDefaultExhaustiveForUnions option description edit

55f761f

kirkwaiblinger requested changes Oct 16, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx Outdated Show resolved Hide resolved

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx Outdated Show resolved Hide resolved

fix:lint error

d594720

developer-bandi requested a review from kirkwaiblinger October 19, 2024 15:07

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 19, 2024

kirkwaiblinger added 3 commits October 27, 2024 00:50

fix heading issue

718c6bb

refactor to tabs

1203a7c

Merge branch 'main' into feature/switch-exhaustiveness-check

b03b724

kirkwaiblinger previously approved these changes Oct 27, 2024

View reviewed changes

kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 27, 2024

kirkwaiblinger requested review from JoshuaKGoldberg and removed request for JoshuaKGoldberg October 27, 2024 07:14

github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 27, 2024

developer-bandi mentioned this pull request Oct 27, 2024

feat(eslint-plugin): [switch-exhaustiveness-check] add support for "no default" comment #10218

Merged

3 tasks

JoshuaKGoldberg previously approved these changes Oct 27, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx Outdated Show resolved Hide resolved

Update packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.mdx

3e1a24e

JoshuaKGoldberg dismissed stale reviews from kirkwaiblinger and themself via 3e1a24e October 27, 2024 15:00

fix text snapshots

76c8716

JoshuaKGoldberg merged commit 3c8978d into typescript-eslint:main Oct 27, 2024
62 checks passed

kirkwaiblinger changed the title ~~feat(eslint-plugin): [switch-exhaustiveness-check] add allowDefaultCaseMatchUnionMember option~~ feat(eslint-plugin): [switch-exhaustiveness-check] add considerDefaultExhaustiveForUnion option Oct 28, 2024

kirkwaiblinger changed the title ~~feat(eslint-plugin): [switch-exhaustiveness-check] add considerDefaultExhaustiveForUnion option~~ feat(eslint-plugin): [switch-exhaustiveness-check] add considerDefaultExhaustiveForUnions option Oct 28, 2024

kirkwaiblinger mentioned this pull request Oct 28, 2024

Bug: [switch-exhaustiveness-check] considerDefaultExhaustiveForUnions is inverted #10222

Closed

4 tasks

JoshuaKGoldberg changed the title ~~feat(eslint-plugin): [switch-exhaustiveness-check] add considerDefaultExhaustiveForUnions option~~ fix(eslint-plugin): [switch-exhaustiveness-check] add considerDefaultExhaustiveForUnions option Oct 29, 2024

JoshuaKGoldberg changed the title ~~fix(eslint-plugin): [switch-exhaustiveness-check] add considerDefaultExhaustiveForUnions option~~ feat(eslint-plugin): [switch-exhaustiveness-check] add considerDefaultExhaustiveForUnions option Oct 29, 2024

kirkwaiblinger mentioned this pull request Oct 30, 2024

Bug: [switch-exhaustiveness-check] False positive with noUncheckedIndexedAccess #10228

Closed

4 tasks

github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): [switch-exhaustiveness-check] add considerDefaultExhaustiveForUnions option #9954

feat(eslint-plugin): [switch-exhaustiveness-check] add considerDefaultExhaustiveForUnions option #9954

developer-bandi commented Sep 8, 2024 •

edited by kirkwaiblinger

Loading

typescript-eslint bot commented Sep 8, 2024

netlify bot commented Sep 8, 2024 •

edited

Loading

nx-cloud bot commented Sep 8, 2024 •

edited

Loading

codecov bot commented Sep 8, 2024 •

edited

Loading

JoshuaKGoldberg left a comment

kirkwaiblinger left a comment

kirkwaiblinger Oct 9, 2024

kirkwaiblinger Oct 9, 2024

kirkwaiblinger Oct 9, 2024

kirkwaiblinger Oct 9, 2024

kirkwaiblinger commented Oct 9, 2024 •

edited

Loading

developer-bandi commented Oct 10, 2024 •

edited

Loading

kirkwaiblinger commented Oct 14, 2024

kirkwaiblinger Oct 15, 2024

developer-bandi Oct 16, 2024

kirkwaiblinger left a comment

kirkwaiblinger left a comment

JoshuaKGoldberg left a comment

		@@ -53,6 +53,29 @@ switch (value) {

		Since `value` is a non-union type it requires the switch case to have a default clause only with `requireDefaultForNonUnion` enabled.

		### `allowDefaultCaseMatchUnionMember`

	description: `If 'true', the 'default' clause is used to determine whether the switch statement is Exhaustive for union type`,
	description: `If 'true', the 'default' clause is used to determine whether the switch statement is exhaustive for union type`,


		Defaults to false. Whether a `default` clause will be considered as making a switch statement over a union type exhaustive.

		By default, if a `switch` statement over a union type includes a `default` case, then it's considered exhaustive.

feat(eslint-plugin): [switch-exhaustiveness-check] add considerDefaultExhaustiveForUnions option #9954

feat(eslint-plugin): [switch-exhaustiveness-check] add considerDefaultExhaustiveForUnions option #9954

Conversation

developer-bandi commented Sep 8, 2024 • edited by kirkwaiblinger Loading

PR Checklist

Overview

typescript-eslint bot commented Sep 8, 2024

netlify bot commented Sep 8, 2024 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Sep 8, 2024 • edited Loading

☁️ Nx Cloud Report

codecov bot commented Sep 8, 2024 • edited Loading

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

kirkwaiblinger left a comment

Choose a reason for hiding this comment

kirkwaiblinger Oct 9, 2024

Choose a reason for hiding this comment

kirkwaiblinger Oct 9, 2024

Choose a reason for hiding this comment

kirkwaiblinger Oct 9, 2024

Choose a reason for hiding this comment

kirkwaiblinger Oct 9, 2024

Choose a reason for hiding this comment

kirkwaiblinger commented Oct 9, 2024 • edited Loading

developer-bandi commented Oct 10, 2024 • edited Loading

kirkwaiblinger commented Oct 14, 2024

kirkwaiblinger Oct 15, 2024

Choose a reason for hiding this comment

developer-bandi Oct 16, 2024

Choose a reason for hiding this comment

kirkwaiblinger left a comment

Choose a reason for hiding this comment

kirkwaiblinger left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

developer-bandi commented Sep 8, 2024 •

edited by kirkwaiblinger

Loading

netlify bot commented Sep 8, 2024 •

edited

Loading

nx-cloud bot commented Sep 8, 2024 •

edited

Loading

codecov bot commented Sep 8, 2024 •

edited

Loading

kirkwaiblinger commented Oct 9, 2024 •

edited

Loading

developer-bandi commented Oct 10, 2024 •

edited

Loading