Skip to content

docs(eslint-plugin): [no-inferrable-types] do not use no-inferrable-types with isolatedDeclarations compiler option #9956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2024
Merged

docs(eslint-plugin): [no-inferrable-types] do not use no-inferrable-types with isolatedDeclarations compiler option #9956

merged 3 commits into from
Sep 23, 2024

Conversation

YuyaYoshioka
Copy link
Contributor

@YuyaYoshioka YuyaYoshioka commented Sep 9, 2024 •
edited
Loading

PR Checklist

Overview

I added documentation stating that no-inferrable-types is incompatible with the isolatedDeclarations compiler option.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @YuyaYoshioka!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Sep 9, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4c510f6
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66ec3ea31ad8b1000864dcbe
😎 Deploy Preview https://deploy-preview-9956--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 9, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4c510f6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@YuyaYoshioka YuyaYoshioka changed the title docs(eslint-plugin): [no-inferrable-types]do not use no-inferrable-types with isolatedDeclarations compiler option docs(eslint-plugin): [no-inferrable-types] do not use no-inferrable-types with isolatedDeclarations compiler option Sep 9, 2024
@YuyaYoshioka YuyaYoshioka marked this pull request as draft September 9, 2024 14:49
@YuyaYoshioka YuyaYoshioka marked this pull request as ready for review September 9, 2024 16:10
@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (7865a55) to head (4c510f6).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9956   +/-   ##
=======================================
  Coverage   88.69%   88.69%           
=======================================
  Files         426      426           
  Lines       14829    14829           
  Branches     4313     4313           
=======================================
  Hits        13153    13153           
  Misses       1533     1533           
  Partials      143      143
Flag Coverage Δ
unittest 88.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@YuyaYoshioka YuyaYoshioka changed the title docs(eslint-plugin): [no-inferrable-types] do not use no-inferrable-types with isolatedDeclarations compiler option docs(eslint-plugin): [no-inferrable-types]do not use no-inferrable-types with isolatedDeclarations compiler option Sep 19, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg changed the title docs(eslint-plugin): [no-inferrable-types]do not use no-inferrable-types with isolatedDeclarations compiler option docs(eslint-plugin): [no-inferrable-types] do not use no-inferrable-types with isolatedDeclarations compiler option Sep 23, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit cdd93f6 into typescript-eslint:main Sep 23, 2024
64 of 68 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
@YuyaYoshioka YuyaYoshioka deleted the fix-9125 branch October 15, 2024 06:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: [no-inferrable-types] Explain whether and how to use (or not use) with isolatedDeclarations
2 participants
@YuyaYoshioka @JoshuaKGoldberg