fix(eslint-plugin): [no-deprecated] report on imported deprecated variables #9987
Conversation
|
Thanks for the PR, @auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3a63482. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9987 +/- ##
=======================================
Coverage 88.67% 88.68%
=======================================
Files 425 425
Lines 14797 14810 +13
Branches 4302 4307 +5
=======================================
+ Hits 13121 13134 +13
Misses 1533 1533
Partials 143 143
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@kirkwaiblinger Sorry, I should turn this PR into draft, but I forgot to do it. One false negative failure in |
| // When we import foo, its symbol is an alias of the exported foo (the one | ||
| // with the deprecated tag), which is itself an alias of the original foo. | ||
| // Therefore, we carefully go through the chain of aliases and check each | ||
| // immediate alias for deprecated tags |
There was a problem hiding this comment.
[Praise] This was very useful, thanks 😄
PR Checklist
Overview
JSDoc tags are attached to the original symbols, not to symbol aliases. But symbols of imported variables are aliases, so we need to resolve those aliases, that's it!