fix(utils): add missing entries to the RuleListener selectors list #9992
Conversation
|
Thanks for the PR, @auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9604bc3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
| @@ -423,7 +423,6 @@ interface RuleListenerBaseSelectors { | |||
| AssignmentExpression?: RuleFunction<TSESTree.AssignmentExpression>; | |||
| AssignmentPattern?: RuleFunction<TSESTree.AssignmentPattern>; | |||
| AwaitExpression?: RuleFunction<TSESTree.AwaitExpression>; | |||
| BigIntLiteral?: RuleFunction<TSESTree.BigIntLiteral>; | |||
There was a problem hiding this comment.
There is no such node as BigIntLiteral, it is just an extension of LiteralBase which have type: AST_NODE_TYPES.Literal.
There was a problem hiding this comment.
Cool, let's try this out 😄
PR Checklist
Overview
I added some tests, and it turns out there were 10 selectors missing!