Skip to content

CONTRIBUTING.md에 Pull Request 방법 추가 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 4, 2020
Merged

CONTRIBUTING.md에 Pull Request 방법 추가 #126

merged 5 commits into from
Aug 4, 2020

Conversation

bumkeyy
Copy link
Member

@bumkeyy bumkeyy commented Aug 2, 2020

No description provided.

@bumkeyy bumkeyy requested review from guyeol and dvlprsh August 2, 2020 14:27
@bumkeyy bumkeyy changed the title Contributing.md에 Pull Request 방법 추가 CONTRIBUTING.md에 Pull Request 방법 추가 Aug 2, 2020
@yeonjuan
Copy link
Contributor

yeonjuan commented Aug 2, 2020

@bumkeyy upstream 설정을 하는 설명도 있으면 좋겠네요 :)

yeonjuan
yeonjuan reviewed Aug 2, 2020
View reviewed changes
yeonjuan
yeonjuan reviewed Aug 2, 2020
View reviewed changes
yeonjuan
yeonjuan reviewed Aug 2, 2020
View reviewed changes
@bumkeyy bumkeyy requested a review from yeonjuan August 2, 2020 15:00
dvlprsh
dvlprsh approved these changes Aug 2, 2020
View reviewed changes
Copy link
Member

@dvlprsh dvlprsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍 👍

dvlprsh
dvlprsh reviewed Aug 2, 2020
View reviewed changes
Copy link
Member

@dvlprsh dvlprsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

린트 에러 수정했습니다~

guyeol
guyeol approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@guyeol guyeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@guyeol guyeol merged commit 572c0ab into master Aug 4, 2020
@bumkeyy bumkeyy deleted the patch-pr branch August 6, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvlprsh dvlprsh dvlprsh approved these changes

@guyeol guyeol guyeol approved these changes

@yeonjuan yeonjuan Awaiting requested review from yeonjuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bumkeyy @yeonjuan @guyeol @dvlprsh