Skip to content

ASP.NET Core 번역 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 30, 2020
Merged

ASP.NET Core 번역 #84

merged 5 commits into from
May 30, 2020

Conversation

nmsohn
Copy link
Contributor

@nmsohn nmsohn commented May 27, 2020 •
edited
Loading

ASP.NET Core page 번역 완료했습니다. 어느 브랜치에 merge해야할 지 몰라 일단 master로 설정해둡니다.

#49

@bumkeyy bumkeyy added this to the v1 번역 milestone May 27, 2020
@bumkeyy bumkeyy linked an issue May 27, 2020 that may be closed by this pull request
Tutorials/ASP.NET Core 번역 #49
Closed
dvlprsh
dvlprsh reviewed May 27, 2020
View reviewed changes
dvlprsh
dvlprsh reviewed May 27, 2020
View reviewed changes
@dvlprsh
Copy link
Member

dvlprsh commented May 27, 2020

고생하셨습니다 😄

@yeonjuan
Copy link
Contributor

@nmsohn 안녕하세요 :)

pages/tutorials/ASP.NET Core.md:35:4 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
pages/tutorials/ASP.NET Core.md:35 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: ""] pages/tutorials/ASP.NET Core.md:73 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: ""]
pages/tutorials/ASP.NET Core.md:83 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: ""] pages/tutorials/ASP.NET Core.md:96 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: ""]
pages/tutorials/ASP.NET Core.md:100:38 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
pages/tutorials/ASP.NET Core.md:102:32 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
pages/tutorials/ASP.NET Core.md:152 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]

Markdown 린팅에서 에러가 나네요 ㅎㅎ 수정해주시면 감사하겠습니다.

@nmsohn
Copy link
Contributor Author

nmsohn commented May 29, 2020

수정 완료했습니다. Linting 하고 나서 라인수가 원본과 좀 달라지기는 했는데 괜찮은가요?

@yeonjuan yeonjuan mentioned this pull request May 30, 2020
Merged
@yeonjuan
Copy link
Contributor

yeonjuan commented May 30, 2020 •
edited
Loading

수정 완료했습니다. Linting 하고 나서 라인수가 원본과 좀 달라지기는 했는데 괜찮은가요?

@nmsohn 넵! 저는 크게 상관없을 것 같아요 작업 감사합니당.
PR을 보니 이미지가 교체된 것 같아서 #86 으로 교체된 이미지 PR 올렸습니다 ㅎㅎ
번역해주셔서 감사합니다!! :)

혹시 머지하시는 분은 #86도 함께 머지해주세요

yeonjuan
yeonjuan approved these changes May 30, 2020
View reviewed changes
Copy link
Contributor

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dvlprsh
Fix markdown format line 190
9a1edbd 
190 라인 # 하나 추가했습니다 (원문 마크다운 형식 통일)
@yeonjuan yeonjuan merged commit 27dc7bc into typescript-kr:master May 30, 2020
@yeonjuan
Copy link
Contributor

@all-contributors please add @nmsohn for translation

@allcontributors allcontributors bot mentioned this pull request May 30, 2020
Merged
@allcontributors
Copy link
Contributor

@yeonjuan

I've put up a pull request to add @nmsohn! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeonjuan yeonjuan yeonjuan approved these changes

@dvlprsh dvlprsh dvlprsh approved these changes

@bumkeyy bumkeyy Awaiting requested review from bumkeyy

@guyeol guyeol Awaiting requested review from guyeol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1 번역
Development

Successfully merging this pull request may close these issues.

Tutorials/ASP.NET Core 번역
4 participants
@nmsohn @dvlprsh @yeonjuan @bumkeyy