-
Notifications
You must be signed in to change notification settings - Fork 167
Visible shell windows are now popping up on Windows 10 #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Need more information since I don't know how to reproduce that locally. For a start, can you provide the logs (stderr) that the server produces on start? |
FWIW, other have reported similar behavior for other language servers.
|
You could try enabling The only related thing that has changed (I believe) is that we never use the If that causes the console to pop up then I'm not sure if there is any way for me to control that. Also you should provide the command line arguments that you use to start the server. That would make it clear whether your code was using |
Thanks, I can confirm that enabling |
For reference this is the place where Typescript starts that process: https://github.com/microsoft/TypeScript/blob/e2c89af335e98003fa3a1cf8ec2acbd41add8a68/src/tsserver/nodeServer.ts#L510-L510
typescript-language-server/src/tsp-client.ts Lines 122 to 128 in 8454554
|
@rchl from the docs it looks like |
Right, missed that. BTW. What is the full command that you are running to that this server? |
Initially: Then from the logs I see the command for tsserver is: |
I don't really know why does this happen for you. Even though I've provided a workaround, I think we could still try to figure out what and why exactly happens here but I'd need to defer that to you or someone else since I don't have a way to look into it. |
Since version 0.8.0 was released, when running this on Windows 10, I'm seeing visible shell windows appear briefly on initialization.
I'm seeing this when running from the main thread of an Electron app.
The text was updated successfully, but these errors were encountered: