[WIP] Resolve completions within LspServer.completion() #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In which cases It might be a correct fix but not sure if it's worth it as it will make the completion response really really slow (like few seconds instead of instantaneous). I've tried on this server's codebase. |
One example is when you're autocompleting a symbol not yet in the current file, and
Hmm, you're right. This PR will need some additional work. |
86e2a8e to
034e3d1
Compare
This allows additionalTextEdits to be provided in the textDocument/completion response while abiding by the guideline here: microsoft/language-server-protocol#924
034e3d1 to
5e44a13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows additionalTextEdits to be provided in the
textDocument/completion response while abiding by the guideline here:
microsoft/language-server-protocol#924
I learned of this today via emacs-lsp/lsp-mode#1713 (comment)