refactor: port ITypeScriptServiceClient #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffebfdf to
5b0cfe3
Compare
size-limit report 📦
|
|
I'm disabling minification of built bundle since I found that otherwise, if the server crashes and reports an error, the whole minified line will be printed in the error message which hides the real error message and stack trace. Also, it's easier to audit changes if built code is not aggressively minifed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor to bring the code closer to the original VSCode implementation and make things easier to port in the future.
This should mostly have no observable differences besides some intentional smaller changes:
tsconfig. New defaults includemoduleResolution: 'bundler'(if TS v5+)target: 'es2022'allowImportingTsExtensions: true(if TS v5+)