Skip to content

fix: avoid sending window/workDoneProgress/create before init #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2024
Merged

fix: avoid sending window/workDoneProgress/create before init #846

merged 2 commits into from
Jan 8, 2024

Conversation

rchl
Copy link
Member

@rchl rchl commented Jan 8, 2024

Don't create loading progress indicator synchronously during initialize request as it's against the spec. It will be created later from tsserver's projectLoadingStart event.

Fixes #845

@github-actions github-actions bot added the fix label Jan 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024 •
edited
Loading

size-limit report 📦

Path Size
lib/cli.mjs 778.5 KB (-0.02% 🔽)

@rchl rchl merged commit 625048f into master Jan 8, 2024
@rchl rchl deleted the fix/init-progress branch January 8, 2024 21:26
@github-actions github-actions bot mentioned this pull request Jan 8, 2024
Merged
@predragnikolic
Copy link
Contributor

Until the server has responded to the initialize request with an InitializeResult, the client must not send any additional requests or notifications to the server. In addition the server is not allowed to send any requests or notifications to the client until it has responded with an InitializeResult, with the exception that during the initialize request the server is allowed to send the notifications window/showMessage, window/logMessage and telemetry/event as well as the window/showMessageRequest request to the client. In case the client sets up a progress token in the initialize params (e.g. property workDoneToken) the server is also allowed to use that token (and only that token) using the $/progress notification sent from the server to the client.

This is copied from the spec, just as a note.

@kaisalmen kaisalmen mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResponseError: Unhandled method window/workDoneProgress/create
2 participants
@rchl @predragnikolic