Skip to content

Update Slavic blocks #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025
Merged

Update Slavic blocks #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cd92e2
Update get_is_reflex() to return Yes when Voice=Mid
Apr 23, 2025
6bc3950
Change PhraseVoice value from Pass to Act for impersonal forms in Pol…
Apr 23, 2025
7841d88
Remove Tense from infinitives in Old Church Slavonic
Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions udapi/block/msf/phrase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ def get_polarity(self, node, neg):
return 'Neg'

def get_is_reflex(self,node,refl):
if node.feats['Voice'] == 'Mid':
return 'Yes'
if len(refl) == 0:
return node.feats['Reflex']
return 'Yes'
Expand Down
2 changes: 1 addition & 1 deletion udapi/block/msf/slavic/past.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def process_node(self, node):
person=node.feats['Person'],
number=node.feats['Number'],
mood=node.feats['Mood'],
voice='Pass',
voice='Act', #In Polish, impersonal statements are annotated with Voice=Act. In Ukrainian, the Voice feature is missing; therefore, we decided to annotate these phrases with PhraseVoice=Act
aspect=node.feats['Aspect'],
form=node.feats['VerbForm'],
polarity=self.get_polarity(node,neg),
Expand Down
7 changes: 5 additions & 2 deletions udapi/block/msf/slavic/preprocessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ def process_node(self,node):
# In Ukrainian, there is no explicit annotation of reflexive verbs
# We decided to unify the annotation of reflexive verbs with Russian and Belarusian, where reflexive verbs are formed similarly
# We add the feature Voice=Mid to reflexive verbs
# This feature is added only to Ukrainian data (for example, there are some verbs in Old Church Slavonic that end in 'сь' but are not reflexive)
if node.upos == 'VERB' and (node.form.endswith('сь') or node.form.endswith('ся')) and self.lang == 'uk':
if node.upos == 'VERB' and (node.lemma.endswith('сь') or node.lemma.endswith('ся')):
node.feats['Voice'] = 'Mid'

# makedonstina tvori budouci cas pomoci pomocneho slova ќе, u nejz neni nijak vyznaceno, ze se podili na tvorbe budouciho casu
Expand Down Expand Up @@ -72,5 +71,9 @@ def process_node(self,node):
if node.feats['Mood'] == 'Sub':
node.feats['Mood'] = 'Cnd'

# # although infinitives in Old Church Slavonic are annotated with Tense=Pres, they do not convey tense; therefore, we remove this annotation
if node.feats['VerbForm'] == 'Inf':
node.feats['Tense'] = ''

# TODO maybe we want to set Tense=Fut for the perfective verbs with Tense=Pres? This could solve the problem with the simplified detection of the future tense in Czech
# but there are many verbs with no Aspect value, so the problem is still there