ICU-23087 Pass null to applyPropertyAlias for a unary property query #3456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we can & should propose to change those to errors. |
I agree. But there will be more changes to UnicodeSet behaviour coming as part of the standardization, so I would like to do that when we have a draft standard to point to. |
markusicu
previously approved these changes
Mar 27, 2025
daa6098 to
908d730
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
markusicu
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only affects users of the internal perpetually-
@draftXSymbolTable (in particular, unicode-org/unicodetools). It makes it possible to distinguish \p{X} (the characters that have binary property X, or that have gc X or script X) from \p{X=} (the characters for which property X is the empty string).Note that ICU allows \p{Whitespace=} for \p{Whitespace}, or \p{L=} for \p{L}. This remains the case with this change, so the public API is unaffected.
Checklist