Add serde Serialize/Deserialize for LanguageIdentifier. #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
reviewed
May 14, 2020
sffc
reviewed
May 14, 2020
echeran
approved these changes
May 15, 2020
| } | ||
|
|
||
| #[test] | ||
| fn deserialize() -> Result<(), Box<dyn std::error::Error>> { |
There was a problem hiding this comment.
Just curious, is the signature of the test to have a return value something specific to SerDe code, a Rust convention, or something else?
There was a problem hiding this comment.
It's a pure convenience - it allows the test function to use ? shorthand operator. I could remove it and replace with .unwrap().
There was a problem hiding this comment.
|
@sffc do you want to remain on the blocking path? If not, I'd prefer if you removed yourself than me removing a pending reviewer :) |
sffc
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple port of zbraniecki/unic-locale#57 which adds serializer/deserializer for
LanguageIdentifierenabled when the crate is compiled withserde.