Inflection-57 Adding support for Swedish from Wikidata #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grhoten
approved these changes
Apr 12, 2025
grhoten
reviewed
Apr 14, 2025
| @@ -134,7 +134,7 @@ ::std::u16string SvGrammarSynthesizer_SvDisplayFunction::inflectWord(const ::std | |||
| ::std::u16string definitenessString(GrammarSynthesizerUtil::getFeatureValue(constraints, &definitenessFeature)); | |||
| ::std::u16string caseString(GrammarSynthesizerUtil::getFeatureValue(constraints, &caseFeature)); | |||
| auto genderString = GrammarSynthesizerUtil::getFeatureValue(constraints, &genderFeature); | |||
| if (genderString.empty()) { | |||
| if (genderString.empty() && GrammemeConstants::NUMBER_SINGULAR() == countString) { | |||
There was a problem hiding this comment.
FYI this line is also included in #106.
|
I'll remove it from my PR, stop the CI and submit.
I'll also take a look at 106
нед, 13. апр 2025. у 20:41 George Rhoten ***@***.***> је
написао/ла:
… ***@***.**** commented on this pull request.
------------------------------
In
inflection/src/inflection/grammar/synthesis/SvGrammarSynthesizer_SvDisplayFunction.cpp
<#104 (comment)>
:
> @@ -134,7 +134,7 @@ ::std::u16string SvGrammarSynthesizer_SvDisplayFunction::inflectWord(const ::std
::std::u16string definitenessString(GrammarSynthesizerUtil::getFeatureValue(constraints, &definitenessFeature));
::std::u16string caseString(GrammarSynthesizerUtil::getFeatureValue(constraints, &caseFeature));
auto genderString = GrammarSynthesizerUtil::getFeatureValue(constraints, &genderFeature);
- if (genderString.empty()) {
+ if (genderString.empty() && GrammemeConstants::NUMBER_SINGULAR() == countString) {
FYI this line is also included in #106
<#106>.
—
Reply to this email directly, view it on GitHub
<#104 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7GEKVB5HRN3PKBQU6N6QL2ZMU5DAVCNFSM6AAAAAB2PPWVYOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONRTGA3DENJYG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…k. Lexicon change stays.
🫡 |
|
Btw, I submitted the #57 but lexicons only (and LFS attribs). If you merged
both lexicons and code from my PR then you should drop the lexicon part
from 106.
пон, 14. апр 2025. у 10:54 George Rhoten ***@***.***> је
написао/ла:
… I'll also take a look at 106
🫡
—
Reply to this email directly, view it on GitHub
<#104 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7GEKXFRHJB6BQO26OAZWD2ZPY5VAVCNFSM6AAAAAB2PPWVYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBSGQ2TMNRZGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*grhoten* left a comment (unicode-org/inflection#104)
<#104 (comment)>
I'll also take a look at 106
🫡
—
Reply to this email directly, view it on GitHub
<#104 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7GEKXFRHJB6BQO26OAZWD2ZPY5VAVCNFSM6AAAAAB2PPWVYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBSGQ2TMNRZGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generated lexicons from the latest (2025-04-02) Wikidata and attempted to fix the test failures. You can see them in the CI output (adding your proposed fix reduced them from 12 to 9). Guidance is appreciated.
Resolves issue #57