Skip to content

Conversation

FrankYFTang
Copy link
Collaborator

@FrankYFTang FrankYFTang commented May 29, 2025

Address #120

@FrankYFTang FrankYFTang changed the title Update ICU version in versions.mk to 77.1 Update ICU version in versions.mk to 77.1 ( issues/120 ) May 29, 2025
@FrankYFTang
Copy link
Collaborator Author

so simply specified the version number is not enough, we need to change the folloiwng line
sudo apt-get update && sudo apt-get install -y libicu-dev icu-devtools

in .github/workflows/cmake-multi-platform.yml to install 77.1

One possible way is to wget the tar ball and unzip from github as
download_77_1
in https://github.com/unicode-org/conformance/blob/main/setup.sh
then do https://github.com/unicode-org/conformance/blob/main/executors/cpp/set_icu4c_binary.sh

to set up

@grhoten grhoten changed the title Update ICU version in versions.mk to 77.1 ( issues/120 ) Inflection-120 Update ICU version in versions.mk to 77.1 May 29, 2025
Copy link
Member

@grhoten grhoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve in principle. Please get the pipeline passing before merging. I suspect that the ICU_ROOT is missing the "local" part of the path. The PATH and LD_LIBRARY_PATH should not be necessary to change.

@FrankYFTang FrankYFTang merged commit 8fbf081 into main May 30, 2025
3 checks passed
@FrankYFTang FrankYFTang deleted the FrankYFTang-patch-1 branch May 30, 2025 23:32
pushd $TMP
tar xvfz *.tgz
rm *.tgz
ls -l icu/usr/local/lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need this line.

deonajulary06 pushed a commit that referenced this pull request Aug 21, 2025
* Update versions.mk

* Update cmake-multi-platform.yml

* Update cmake-multi-platform.yml

* Update cmake-multi-platform.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants