Add CI for valgrind fix issues/118 #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
macOS normail build CI take 2m5s to run, ubuntu take 3m24s to run, checkmemleak take 5m25s to run |
|
@nciric Please review |
|
Fix #118 |
|
See https://github.com/FrankYFTang/inflection/actions/runs/15430643627/job/43427674705 for the test run |
nciric
reviewed
Jun 4, 2025
There was a problem hiding this comment.
I see two ways to go here:
- Remove duplication of ICU checkout and some checkout steps (we are potentially paying 2x for LFS checkout) and keep everything in this file
- Create a new workflow (e.g. ubuntu-memory-check.yml) and move your valgrind logic there. You will need to copy some of the triggering logic from this file.
I address both issues . PTAL |
nciric
approved these changes
Jun 5, 2025
deonajulary06
pushed a commit
that referenced
this pull request
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #118