Skip to content

Cache LFS content (fix issue/127) #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 30, 2025
Merged

Cache LFS content (fix issue/127) #128

merged 7 commits into from
Jun 30, 2025

Conversation

FrankYFTang
Copy link
Collaborator

Fix #127

@FrankYFTang
Copy link
Collaborator Author

Test run on
https://github.com/FrankYFTang/inflection/actions/runs/15597515786
and
https://github.com/FrankYFTang/inflection/actions/runs/15597601844

@FrankYFTang FrankYFTang requested a review from nciric June 11, 2025 23:08
nciric
nciric reviewed Jun 12, 2025
View reviewed changes
@FrankYFTang
Copy link
Collaborator Author

hum... somehow got the following errors

[ 47%] Generating ../inflection_data/usr/local/share/inflection/dictionary/mmappable_ar.sdict
Dictionary written for ar
[ 47%] Generating ../inflection_data/usr/local/share/inflection/dictionary/mmappable_da.sdict
Entity: line 1: parser error : Start tag expected, '<' not found
version https://git-lfs.github.com/spec/v1
^
terminate called after throwing an instance of 'inflection::exception::IOException'
  what():  /home/runner/work/inflection/inflection/inflection/resources/org/unicode/inflection/dictionary/inflectional_da.xml
[ 49%] Building CXX object src/CMakeFiles/inflection.dir/inflection/dialog/LocalizedCommonConceptFactoryProvider.cpp.o
Aborted (core dumped)
gmake[2]: *** [resources/CMakeFiles/inflection-data.dir/build.make:112: inflection_data/usr/local/share/inflection/dictionary/mmappable_da.sdict] Error 134
gmake[2]: *** Deleting file 'inflection_data/usr/local/share/inflection/dictionary/mmappable_da.sdict'
gmake[1]: *** [CMakeFiles/Makefile2:884: resources/CMakeFiles/inflection-data.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....

@FrankYFTang FrankYFTang requested a review from nciric June 27, 2025 22:24
@FrankYFTang FrankYFTang merged commit 2ba332e into unicode-org:main Jun 30, 2025
1 check passed
@FrankYFTang FrankYFTang deleted the cache-lfs branch June 30, 2025 18:57
deonajulary06 pushed a commit that referenced this pull request Aug 21, 2025
@FrankYFTang @deonajulary06
Cache LFS content (fix issue/127) (#128)
3eefc23 
* Cache LFS content (fix issue/127)

and fix icu cache by adding save action

* only perform lfs action if missed the cache

* Add ls to debug the content restored

* Debug

* Correct path

* fix

* Remove dupicate lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nciric nciric nciric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cache lfs in github action
2 participants
@FrankYFTang @nciric