Inflection 134 std::unique_ptr for KoGrammarSynthesizer_ParticleResol… #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grhoten
reviewed
Jun 27, 2025
| @@ -76,7 +75,7 @@ std::u16string KoGrammarSynthesizer_ParticleResolver::getRelevantString(std::u16 | |||
| } | |||
| if (!strToTokenize.empty() && !inflection::lang::StringFilterUtil::HANGUL_SCRIPT().contains((UChar32)inflection::util::StringViewUtils::codePointAt(strToTokenize, int32_t(strToTokenize.length() - 1)))) { | |||
| // We don't care about the strings in the phonetic Hangul script. Return the relevant last word to check without punctuation. | |||
| std::unique_ptr<inflection::tokenizer::TokenChain> tokenChain(npc(npc(englishTokenizer)->createTokenChain(std::u16string(strToTokenize)))); | |||
| std::unique_ptr<inflection::tokenizer::TokenChain> tokenChain(npc(englishTokenizer->createTokenChain(std::u16string(strToTokenize)))); | |||
There was a problem hiding this comment.
Please ensure that englishTokenizer gets an npc check during construction, since you're removing it from here.
grhoten
approved these changes
Jun 28, 2025
deonajulary06
pushed a commit
that referenced
this pull request
Aug 21, 2025
#141) * Inflection 134 std::unique_ptr for KoGrammarSynthesizer_ParticleResolver.cpp * add npc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#134